[Bug 13149] New: Bug 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bug ID: 13149 Summary: Bug 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.ql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea@gmail.com Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org Because of this bug, installing Koha's default databse fails because sysprefs cannot be installed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11926 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wizzyrea@gmail.com |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 32789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32789&action=edit Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 11926 (HEA - Render |B 11926 (HEA - Render |community koha statistic |community koha statistic |usages) introduces an |usages) introduces an |column count error in |column count error in |sysprefs.ql |sysprefs.ql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Setting severity to major, because this seriously hampers newcomers from enjoying their seamless Koha experience. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32789|0 |1 is obsolete| | --- Comment #3 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32792&action=edit Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql I've applied against master 3.17.00.031 Without this patch, on web-installing the DB, at the 3-rd step I saw: sysprefs.sql ERROR 1136 (21S01) at line 1: Column count doesn't match value count at row 431 After having applied the patch, web-installing the DB ends cleanly. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I feel like the patch is not complete - all UsageStats* have the wrong field order. Testing a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32800&action=edit Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My new patch applies on top of Kivilahti's, fixing the other UsageStats* prefs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32792|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 32803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32803&action=edit [SIGNED-OFF] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32800|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 32804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32804&action=edit [SIGNED-OFF] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32803|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32824&action=edit [PASSED QA] Bug 13149 - for B 11926 (HEA - Render community koha statistic usages) introduces an column count error in sysprefs.sql REPLICATE: 1. Create a new Koha database to your SQL Server. Set proper user permissions. 2. Change database data source definitions in koha-config.xml. 3. Run the web-installer to install a new Koha with defaults. 4. Run "SELECT * FROM systempreferences;" in your SQL Server and observe only 3 systempreferences set. +--------------------------+ (( 5. mainpage.pl crashes!! )) +--------------------------+ AFTER THIS COMMIT: 0. Redo REPLICATE steps. 1. test phase 4 returns over 400 results. 2. test phase 5 doesn't crash. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32804|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 32825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32825&action=edit [PASSED QA] Bug 13149: Fix sequence of fields in sysprefs.sql The sequence of fields in the SQL statement didn't match correctly. Test plan: - Run the web installer on an empty database - Make sure no SQL errors are shown - Check the systempreferences table in your database, especially all UsageStats* - Make sure the explanations are in explanation etc. Alternatively: - Save your database - truncate systempreferences; - Load the sql file sysprefs.sql - Verfiy as above Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Tested creating new database, then loading kohastructure and sysprefs.sql Without patch sysprefs fails to load, with patch loads Ok! No koha-qa errors Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Olli and Katrina -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 --- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Lol that was the fastest push to master ever. Thank you Katrin for spotting the bug and providing a fix! Good initiative! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13585 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13149 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13585 Depends on|13585 | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org