[Bug 18304] New: Do not mail cart or list contents to the library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Bug ID: 18304 Summary: Do not mail cart or list contents to the library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61285&action=edit Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61285|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 61317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61317&action=edit Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61317|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61339&action=edit Bug 18304: Do not mail cart or list contents to the library Sometimes we receive mails from patrons, sent from opac-sendbasket or opac-sendshelf. Instead of placing a hold on books they send the contents of the cart (or even a list). This patch simply puts a note on both forms saying that they should not use the mail to request or renew books. If both options are disabled on the OPAC, the message is not shown. Test plan: [1] Enable RequestOnOPAC. [2] Put a book in the cart. [3] Open the cart, click on Send. Verify presence of the message. [4] Open a list. [5] Click on Send list. Verify presence of the message. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we please add an id/class to this? We have at least one library who pulls the books from the shelves using the cart and doesn't allow on-shelf-holds. This would allow us to change/hide the note using CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 61346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61346&action=edit Bug 18304: [QA Follow-up] Add id to paragraph tag See Bugzilla, comment 4. Note: the id is unique in the Koha codebase (git grepped). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org