[Bug 10764] New: Update POD of C4::Items::GetItemStatus() to use TT syntax
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Bug ID: 10764 Summary: Update POD of C4::Items::GetItemStatus() to use TT syntax Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Documentation Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The POD of C4::Items::GetItemStatus() has an example of how to create a selector based on the output of the function, but it uses the old template syntax, not TT syntax. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20482&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8670 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20482|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- Created attachment 20494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20494&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. Signed-off-by: Magnus Enger <magnus@enger.priv.no> This patch works as advertised (verified with "perldoc C4::Items"), for GetItemStatus, but it does not fix a a similar example for GetItemLocation in the same file, which still has the old template syntax. So a followup or separate bug for that is called for. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20494|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20500&action=edit Bug 10764 - Update POD of C4::Items::GetItemStatus() to use TT syntax This patch updates the example template syntax in the POD for C4::Items::GetItemStatus() to use Template Toolkit syntax. To test, view the POD for C4::Items::GetItemStatus() and confirm that it looks correct. Signed-off-by: Magnus Enger <magnus@enger.priv.no> This patch works as advertised (verified with "perldoc C4::Items"), for GetItemStatus, but it does not fix a a similar example for GetItemLocation in the same file, which still has the old template syntax. So a followup or separate bug for that is called for. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It seems the default option is not in used in templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10764 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.20. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org