[Bug 21729] New: When reverting a hold the expirationdate should be reset?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Bug ID: 21729 Summary: When reverting a hold the expirationdate should be reset? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com See bug 21608 and bug 21611 - existing behvaiour from 17.11 is restored by those bugs - but it is possible we should consider broader options for what happens when a hold is reset from 'found' status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21608 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The issue is that when a hold is found the expiration date set by the patron (not needed after...) is overwritten by the latest possible pick-up date if that is after the expiration date. This means there is no way we can revert a hold from waiting in a clean way. Currently the expirationdate is kept when reverting, which means that we will have all reverted holds expire - for a short pick-up time set... they will expire very soon after reverting. I think the only thing we can do is set the expirationdate to blank. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When reverting a hold the |When reverting a hold the |expirationdate should be |expirationdate should be |reset? |reset -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew <andrew@bywatersolutions.com> --- *** Bug 23052 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 21932 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bug 21032 among others has suggested that we have a separate database field for the expiration date or the waiting date - I agree this is the right fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov --- Comment #5 from Peggy Thrasher <p.thrasher@dover.nh.gov> --- This is causing a lot of confusing in my library. It would be great to have this fixed. Thanks! Peggy - Dover Public Library NH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #4)
Bug 21032 among others has suggested that we have a separate database field for the expiration date or the waiting date - I agree this is the right fix.
I agree. There should be separate fields. Having a double use of the same field was a mistake, in my opinion. These dates need to be retained separately. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #7 from Lisette Scheer <lisetteslatah@gmail.com> --- On master the expiration date can be edited/cleared once the hold is reverted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Katrin Fischer from comment #4)
Bug 21032 among others has suggested that we have a separate database field for the expiration date or the waiting date - I agree this is the right fix.
+1. This would be an ideal solution. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Brenda <bowens@washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bowens@washoecounty.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #9 from Rebecca Coert <rcoert@arlingtonva.us> --- +1 this would be very helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se --- Comment #10 from Klas Blomberg <klas.blomberg@skovde.se> --- +1 for creating a separate field. This is how it worked in my previous ILS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #11 from Chris Slone <cslone@camdencountylibrary.org> --- We've just run into some issues with the expiration date not reverting when an awaiting copy was checked out to a different patron... Definitely would be better if the expiration date was cleared/reset than for it to hang on to the expiration date set when the first item was confirmed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126160&action=edit Bug 21729: DB changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126161&action=edit Bug 21729: DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126162&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- These patches are not ready for inclusion (missing test coverage) but I'd like to get a first iteration with testers to know if it will be answer your needs and the different use cases. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The system preference DefaultHoldExpirationdate puts a date into expirationdate but not your new patron_expiration_date field: expirationdate: 2021-10-23 patron_expiration_date: NULL Further, if I've set the DefaultHoldExpirationdate syspref to make holds expire in X days, but manually pick a non-X value when placing the hold, I get different values in the two fields. Here my syspref is set to 10 days, but I picked a nearer date when placing the hold. Koha shows 10/23 as the expiration date on the bib and borrower pages. expirationdate: 2021-10-23 patron_expiration_date: 2021-10-15 After I check the item in and set it to Waiting status, the patron_expiration_date does start to get enforced. (In this case, my patron_expiration_date ends up less than waitingdate+ReservesMaxPickUpDelay.) waitingdate: 2021-10-13 expirationdate: 2021-10-15 patron_expiration_date: 2021-10-15
From that point, my expiration date remains 10/15 if I revert the hold, recapture it, etc.
Seems like we should make the syspref write its date into both expirationdate and patron_expiration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Oh! It's gets very angry if you don't set an expiration date at all when placing the hold. I turned off DefaultHoldExpirationdate and made a hold without an expirationdate. I checked the item in and confirmed the hold but Koha didn't set ANY expiration date: found: W timestamp: 2021-10-13 12:34:01 itemnumber: 1 waitingdate: 2021-10-13 expirationdate: NULL patron_expiration_date: NULL And I get an error when I try to look at Holds Awaiting Pickup: Date::Calc::Date_to_Days(): not a valid date at /kohadevbox/koha/circ/waitingreserves.pl line 103 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- All that said, if I've created and captured a hold that started with an expiration date, reverting the hold's waiting status *is* successfully setting the expiration date back to what the patron selected when placing the hold! I tested both reversion via request.pl and via checkout of the item to another patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126162|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126203&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Thanks Andrew! I found some obvious issues in the previous patch and it will (hopefully) fix what you found. I haven't the time right now to retest the different combinations, but the patch is ready for testing again if you want to give it another try! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 126258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126258&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26498 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |florian.bontemps@biblibre.c | |om --- Comment #22 from Florian <florian.bontemps@biblibre.com> --- Would like to sign off, should I use the test plan in bug 21932 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Florian from comment #22)
Would like to sign off, should I use the test plan in bug 21932 ?
Yes, that should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #24 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- To test: APPLY PATCH 1 - create a hold with an expiration date sooner than the period defined by your MaxPickupDelay 2 - check your item in, triggering the hold, confirm the expiration date doesn't change 3 - revert your hold, confirm the expiration date doesn't change 4 - create a hold with an expiration date past the period defined by your MaxPickupDelay 5 - check your item in, triggering the hold, confirm the expiration date changes 6 - Revert your hold, confirm the expiration date reverts back to its original value 7 - create a hold with no expiration date 8 - check your item in, triggering the hold, confirm an expiration date is created 9 - revert your hold, confirm the expiration date is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126160|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127797&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126161|0 |1 is obsolete| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127798&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126203|0 |1 is obsolete| | --- Comment #27 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127799&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126258|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127800&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #29 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127867&action=edit Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff Usage: POSIX::exit(status) at /kohadevbox/koha/tags/review.pl line 72. at /usr/share/perl/5.28/Carp.pm line 289 Carp::croak('Usage: POSIX::exit(status)') called at /usr/lib/x86_64-linux-gnu/perl/5.28/POSIX.pm line 22 POSIX::usage('exit(status)') called at (eval 2066) line 3 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #30 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127868&action=edit Bug 29270: Expiration date must be in future Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #31 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127869&action=edit Bug 29477: Flatpickr - default to 23:59 for the time part It was defaulting to 12:00 which was an unexpected change in behaviour caused by flatpickr switch. Test plan: On the circulation view, check some items out and play with the time part and "Remember for session". The behaviour must be correct, ie. the same as prior to flatpickr switch. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #32 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127870&action=edit Bug 29270: start_for is actually date_to The attribute has been renamed in the meanwhile.. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Florian, to obsolete patches you need to click "Details", "edit details", tick "obsolete", then submit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127867|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | Attachment #127869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127868|0 |1 is obsolete| | Attachment #127869|0 |1 is obsolete| | Attachment #127870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127797|0 |1 is obsolete| | --- Comment #34 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127877&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127798|0 |1 is obsolete| | --- Comment #35 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127878&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127799|0 |1 is obsolete| | --- Comment #36 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127879&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127800|0 |1 is obsolete| | --- Comment #37 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127880&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #38 from Florian <florian.bontemps@biblibre.com> --- Apologies for the mess I caused, hopefully all should be good. Sidenote though : I was able to run the full test plan without the patches on master, and it worked as intented; so in essence I saw no differences with or without the patches. Maybe it was fixed elsewhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |tomascohen@gmail.com Status|Signed Off |Failed QA --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Any plans on adding the missing tests soon? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #40 from Florian <florian.bontemps@biblibre.com> --- Here is the test plan I followed, from the 21932. To test flaws: 1) Place a first available hold for the next available item, and set the hold expires date to a short time, like tomorrow. 2) Make sure your ReservesMaxPickUpDelay setting is set for longer that a day. Say 7 days, for example. 3) View the hold. Note the expiration date is set. 4) Check in the item and trigger the hold. See that the item is waiting. Note the expiration is set to the patron's preferred expiration date. 5) Set the priority back to 1, and update the hold. Note that the hold is now an item specific hold instead of a next available hold. 6) Note the expiration stayed. This is okay in this instance. 7) Cancel the hold and start over. 8) Place a first available hold for the next available item, but do not set the hold expires date. 9) View the hold. Note the expiration date is not set. 10) Check in the item and trigger the hold. See that the item is waiting. Not the expiration date is set. 11) Set the priority back to 1, and update the hold. Note that the hold is now an item specific hold instead of a next available hold. 12) Note the expiration stayed. This is not okay in this instance. The patron's hold will disappear after the date! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128761&action=edit Bug 21729: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127877|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129090&action=edit Bug 21729: DB changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127878|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129091&action=edit Bug 21729: DBIC schema changes Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127879|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129092&action=edit Bug 21729: Keep expiration date set when placing a hold The expiration date picked by the patron (or librarian) when placing a hold is lost when a waiting hold is reverted. We need a separate DB field to store this value and restore it when needed: patron_expiration_date The new behaviours are now: Create a hold and specify an expiration date: expirationdate=patron_expiration_date Fill the hold: expiration_date is calculated expiration_date set to the calculated value or to patron_expiration_date if anterior patron_expiration_date not modified Revert the waiting status: expirationdate set back to patron_expiration_date Cancel expire reserves: if < expirationdate OR < patron_expiration_date Note: This change should not be needed but won't hurt Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127880|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129093&action=edit Bug 21729: Simplify non-existent expiration date No change in behaviour expected by this patch. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128761|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129094&action=edit Bug 21729: Add tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|tomascohen@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All working as expected, code is clear. QA scripts happy, includes unit tests.. which read well and are passing. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- While pushing I will add semi-colon to dbrev, see Bug 29813 And I recreated DBIC shema changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- This change in behavior needs a nice release note :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #50 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29975 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29975 [Bug 29975] (Bug 21729 followup) patron_expiration_date missing in API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29976 [Bug 29976] (Bug 21729 followup) fix holds unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oooo test suite broken ^^ I've created 2 new bug reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org