[Bug 13612] New: Remove old YUI javacript libraries from opac-tmpl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Bug ID: 13612 Summary: Remove old YUI javacript libraries from opac-tmpl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org After checking with Owen it appears that the opac-tmpl/lib/yui directory can be removed now that we only support Bootstrap OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 35470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35470&action=edit Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- I did git grep for the files all removed files, no references behalve of: git grep 'opac-tmpl/lib/yui/reset-fonts-grids.css' Result: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css git grep 'opac-tmpl/lib/yui/skin.css' Result: koha-tmpl/opac-tmpl/bootstrap/css/opac-old.css koha-tmpl/opac-tmpl/bootstrap/css/sco-old.css Are opac-old.css and sco-old.css still used / present in the system or is this just a local issue in my dev installation? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marc, I have the same result, but the css files don't seem to be linked to from anywhere. My guess is, that we kept them around for look-up, but that they are not used any longer. Owen, could you confirm? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
Owen, could you confirm?
I confirm. opac-old.css and sco-old.css were in-development reference files and shouldn't have made it into the original patch. They can be ignored for the purposes of this patch and deleted by another one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 35793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35793&action=edit [Signed-off] Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. No references found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13689 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35793|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35822&action=edit Bug 13612 - Remove old YUI javacript libraries from opac-tmpl YUI files were left behind in opac-tmpl/lib/yui after the removal of the prog theme. These files are unused and can be safely removed. To test, apply the patch and search for references to any of the YUI files. You should find none in the OPAC templates. No references found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13689 CC| |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #4)
Owen, could you confirm?
I confirm. opac-old.css and sco-old.css were in-development reference files and shouldn't have made it into the original patch. They can be ignored for the purposes of this patch and deleted by another one.
I am marking this bug depends on bug 13689, IMO they should be pushed together. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13612 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org