http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 24250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24250&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #2 from Francesca <francescalamoore@gmail.com> --- Created attachment 24264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24264&action=edit Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore <francescalamoore@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I ran into a problem with the test plan. t/Installer.t doesn't exist prior to this patch. Is this patch introducing a new test, or is this supposed to be an improvement of t/Installer_pm.t? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Chris Cormack from comment #4)

Ah yes, this new patch tests

C4::Installer

t/Installer_pm.t on the other hand tests C4::Installer::PerlModules

So yep, it is a new test file.

Cool. In that case, don't we need to add a call to this test elsewhere in Koha? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24250|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24299&action=edit Bug 11541 [Followup] - Increasing test coverage for C4::Installer Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24297|0 |1 is obsolete| | --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 24303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24303&action=edit Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24299|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 24306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24306&action=edit Bug 11541 [Followup] - Increasing test coverage for C4::Installer Tests succeed, but cause many warnings: prove t/Installer.t t/Installer.t .. 1/9 "my" variable $self masks earlier declaration in same scope at t/Installer.t line 19. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 20. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 21. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 22. "my" variable $self masks earlier declaration in same scope at t/Installer.t line 23. Odd number of elements in anonymous hash at t/Installer.t line 17. Use of uninitialized value within @ARGV in anonymous hash ({}) at t/Installer.t line 17. The patch remedies that. Test Plan: 1) Apply first patch on this bug 2) Run "prove t/Installer.t" 3) Note the warnings 4) Apply this patch 5) Repeat step 2 6) Note the warnings are gone Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24303|0 |1 is obsolete| | Attachment #24306|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24314&action=edit [PASSED QA] Bug 11541: Increasing coverage of Installer.pm To test 1. Run prove t/Installer.t 2. Apply patch 3. Run prove t/Installer.t Notice more tests are run Signed-off-by: Francesca Moore <francescalamoore@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11541 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a couple follow-ups to put the test in the db_dependent subdirectory and test the values of the fields in the $installer object more precisely. Congratulations on having your first patch accepted into Koha, Aleisha! -- You are receiving this mail because: You are watching all bug changes.