[Bug 22010] New: RecordedBooks and OverDrive should check preferences over passing variables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Bug ID: 22010 Summary: RecordedBooks and OverDrive should check preferences over passing variables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Currently RecordedBooks circulation throws an error on the user account page for 'SPINNER_THROBBER' undefined The param is not passed to the template on that page - rather than passing it we should make the checks in the template -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Depends on| |17602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602 [Bug 17602] Integrate support for RecordedBooks (formerly OneClickDigital) API -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83279&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jrobb@sekls.org --- Comment #2 from Jason Robb <jrobb@sekls.org> --- I tested this patch with my RB credentials. The searching works and my account syncs up correctly on opac-recordedbooks-search.pl -- I can check out items, place holds, check in items, etc. from those results. opac-user.pl is still throwing the SPINNER_THROBBER error, and I still don't see content in the RB Account tab. Applying the patch causes this string to appear at the very bottom of opac-user.pl, both with valid and invalid RBdigital credentials set in the sysprefs: var SPINNER_THROBBER = "/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif"; I had to scroll down slightly to see it. Inspecting the html shows that string listed among the other scripts but without any tags, like this: <script src="/opac-tmpl/bootstrap/js/tags_18.1200017.js"></script> var SPINNER_THROBBER = "/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif"; <script src="/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.cookie.min_18.1200017.js"></script> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83279|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88378&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jason Robb from comment #2) Added missing script tags, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88378|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88775&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88775|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 89056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89056&action=edit Bug 22010: Check preferences for ebook integration To test: 1 - Enable OverDrive and RecordedBooks (you can put anything in the prefs) 2 - Search on the opac - verify you get results (or search error) on first page of results' 3 - Go to second page of results - OD and RB are not searched 4 - Apply patch 5 - Verify nothing has changed If you have valid credentials: 1 - Enable RB prefs 2 - Sign in with an account that has an email matching your registered account for recordedbooks 3 - Confirm you RB account loads on opac-user.pl Otherwise: Read the patches, verify it all makes sense Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable Version(s)| |19.05.00, 18.11.06 released in| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22010 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies, wont backport to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org