[Bug 5485] New: Add a framework for static source code analysis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Summary: Add a framework for static source code analysis Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Koha is very poor in test coverage. Add a script that will allow the option of using perlcritic to run static analysis on the perlcode. At present most code will fail these tests but using Test::Perl::Critic may encourage use of better practices in the source, Important that running of the tests is purely optional and does not add dependencies on the end user so script is conditional on setting an environment variable and the requisite module being installed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 --- Comment #1 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-08 11:12:56 UTC --- This bug is mentioned in: Bug 5485: Add script to run Test::Perl::Critic http://lists.koha-community.org/pipermail/koha-patches/2010-December/013244.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-15 13:45:13 UTC --- The script works well and all tests were successful ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-15 13:45:44 UTC --- Created attachment 3302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3302 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-16 23:45:40 UTC --- Pushed, please test and mark resolved I will set Jenkins to begin running these, and maybe add a dir at a time and encourage people to fix the tests that will udoubtedly fail -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5485 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #5 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-03 23:22:49 UTC --- This bug is mentioned in: Bug 5485: Add script to run Test::Perl::Critic http://lists.koha-community.org/pipermail/koha-patches/2011-March/014055.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org