https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92028&action=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #2 from Lisette Scheer <lisetteslatah@gmail.com> --- *** Bug 23209 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92028|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92072&action=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch doesn't apply for me :( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23434-Hold-confirmation-dialog-problem-if-Hold-wUIahn.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92072|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92082&action=edit Bug 23434: Hold confirmation dialog problem if HoldsAutoFill is enabled This patch corrects a problem with hold confirmation dialogs on the checkin page when the HoldsAutoFill system preference is enabled and the item being checked in has a hold at another library. The confirmation dialog is converted to a modal to match other confirmation information. As part of this process two whole sections of the template have been removed because they were redundant. To test, apply the patch and test the following circumstances both with HoldsAutoFill enabled AND disabled: - A hold for a patron at your library - A hold for a patron not at your library - With HoldsAutoFill ON, both the "OK" and "Print slip and confirm" buttons should dismiss the modal without reloading the page. - A hold which is already marked 'Waiting' - An item which needs to be transferred - An item which has already been transferred In all cases the confirmation modal should appear with correct information. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Bug 23434 depends on bug 23399, which changed state. Bug 23399 Summary: Reindent returns.tt https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23399 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Vinod <mishravk79@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bwsdonna@gmail.com, |mishravk79@gmail.com |fridolin.somers@biblibre.co | |m, lisetteslatah@gmail.com, | |martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23434 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.