[Bug 22434] New: correct item callnumber search link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Bug ID: 22434 Summary: correct item callnumber search link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 85879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85879&action=edit Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi, I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Theodoros Theodoropoulos <theod@lib.auth.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #4 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 86132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86132&action=edit Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item Signed-off-by: Theodoros Theodoropoulos <theod@lib.auth.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod@lib.auth.gr --- Comment #5 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- The proposed patch seems to work with the latest master (as of today) and with minor changes can be backported to 17.xx Thanks Fridolin for taking time to work on this issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you explain the issue you are trying to fix? Without the patch: I have an item with its callnumber set to AAA&1(2)3 I launch a search and see a link /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 I click on it and I am redirected to the bibliographic detail page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #2)
Hi,
I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'?
Cheers, Hayley
Hayley, you need to create a library group (Home › Administration › Library groups) with the "Use for staff search groups" feature, then on the advanced search form you will see it at the bottom of the page ("Groups of libraries"). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #8 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #7)
(In reply to Hayley Mapley from comment #2)
Hi,
I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'?
Cheers, Hayley
Hayley, you need to create a library group (Home › Administration › Library groups) with the "Use for staff search groups" feature, then on the advanced search form you will see it at the bottom of the page ("Groups of libraries").
Thanks for letting me know Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
Could you explain the issue you are trying to fix?
Without the patch: I have an item with its callnumber set to AAA&1(2)3 I launch a search and see a link /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 I click on it and I am redirected to the bibliographic detail page.
Using idx=callnum will use all search options like the auto-trunction for example, that is useless in this case. Many places like the facets prefer <index>:<query>. This is also good for ES. And some places where missing the double quotes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I tried rebasing this one for QA but found a couple of cases where I wasn't 100% sure of the intention as as such have deferred it back to "Patch doesn't apply" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|correct item callnumber |Correct item callnumber |search link |search link CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Oh but I don't remember adding [ and ] Needs rework. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #11)
Oh but I don't remember adding [ and ] Needs rework.
Ahhhh [ is for [, because its part of the TT syntaxe [% ... In the end this change is not very usefull, i close. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org