https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21523 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I think it would also be more consistent to put the information in a separate tab. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21523 [Bug 21523] Switch two-column templates to Bootstrap grid: Serials part 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't show acquisition |Don't show acquisition |details on subscrpition |details on subscription |detail when there is no acq |detail when there is no acq |data |data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80301&action=edit Bug 21511: Don't show acquisition details on subscription detail when there is no acq data This patch modifies the subscription detail page so that acquisitions details section is not shown when there is no acquisitions data. The acquisitions details are moved into a new tab similar to how it appears on the bibliographic details page. A count of orders is now passed to the template so that the check for existing acquisitions data will work correctly. To test, apply the patch and view the detail page for subscriptions. - When viewing a subscription for which there are orders you should see an "Acquisitions details" tab containing the acquisitions data. - When viewing a subscription with no orders the tab should not appear. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80301|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80424&action=edit Bug 21511: Don't show acquisition details on subscription detail when there is no acq data This patch modifies the subscription detail page so that acquisitions details section is not shown when there is no acquisitions data. The acquisitions details are moved into a new tab similar to how it appears on the bibliographic details page. A count of orders is now passed to the template so that the check for existing acquisitions data will work correctly. To test, apply the patch and view the detail page for subscriptions. - When viewing a subscription for which there are orders you should see an "Acquisitions details" tab containing the acquisitions data. - When viewing a subscription with no orders the tab should not appear. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80424|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80438&action=edit Bug 21511: Don't show acquisition details on subscription detail when there is no acq data This patch modifies the subscription detail page so that acquisitions details section is not shown when there is no acquisitions data. The acquisitions details are moved into a new tab similar to how it appears on the bibliographic details page. A count of orders is now passed to the template so that the check for existing acquisitions data will work correctly. To test, apply the patch and view the detail page for subscriptions. - When viewing a subscription for which there are orders you should see an "Acquisitions details" tab containing the acquisitions data. - When viewing a subscription with no orders the tab should not appear. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Owen, can you confirm this follow up works for you? removes the need to add an additional parameter to the template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21511 Bug 21511 depends on bug 21523, which changed state. Bug 21523 Summary: Switch two-column templates to Bootstrap grid: Serials part 2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21523 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.