[Bug 32932] New: Re-structure Vue router-links to use "name" instead of urls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Bug ID: 32932 Summary: Re-structure Vue router-links to use "name" instead of urls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: matt.blenkinsop@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Currently the Vue router is set up with urls assigned to components with no "name" property. This means that in the components, where a router-link tag is used the full URL has been written out again. In the event that a url needs to be changed in the router, the url will also have to be changed in every component that uses that route. By using the "name" property we can avoid this and make maintenance of the router much more efficient. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146439&action=edit Bug_32932: Update router to use object references This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146439|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146442&action=edit Bug_32932: Update router to use object references This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart+koha@gmail. |matt.blenkinsop@ptfs-europe |com |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146442|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146616&action=edit Bug_32932: Update router to use object references This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146617&action=edit Bug_32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146618&action=edit Bug 32932: Update router to use name property for licences As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146624&action=edit Bug 32932: Update router to use name property for eholdings As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146625&action=edit Bug 32932: Update ermmain to use router name property Updating the router links in the homepage as per previous commits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146617|0 |1 is obsolete| | --- Comment #8 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 146965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146965&action=edit Bug_32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146618|0 |1 is obsolete| | --- Comment #9 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 146966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146966&action=edit Bug 32932: Update router to use name property for licences As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146624|0 |1 is obsolete| | --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 146967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146967&action=edit Bug 32932: Update router to use name property for eholdings As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146625|0 |1 is obsolete| | --- Comment #11 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Created attachment 146968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146968&action=edit Bug 32932: Update ermmain to use router name property Updating the router links in the homepage as per previous commits Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Will need rebasing once bug 32983 and its dependency tree are pushed to master as routes.js has moved/been renamed. I'll apply the dependency tree and rebase, then re-submit once master is up to date with current ERM refactoring work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32983 [Bug 32983] Use REST API route to retrieve authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146965|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147119&action=edit Bug_32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146966|0 |1 is obsolete| | --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147120&action=edit Bug 32932: Update router to use name property for licences As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146967|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147121&action=edit Bug 32932: Update router to use name property for eholdings As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146968|0 |1 is obsolete| | --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 147122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147122&action=edit Bug 32932: Update ermmain to use router name property Updating the router links in the homepage as per previous commits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- REBASED: Now depends on 32983 to reflect current refactoring work. Test plan as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33169 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Agustín Moyano <agustinmoyano@theke.io> --- With the new dialog implementation there are no more '*Delete.vue' files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 148115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148115&action=edit Bug 32932: (rebase) Rebased on top of bug 32991 This patch rebases on top of changes made in bug 32991 and also fixes an incorrect router reference in EHoldingsLocalTitlesFormAdd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Agustín Moyano <agustinmoyano@theke.io> --- Patch still doesn't apply: 14:43 $ git bz apply 32932 Bug 32932 - Re-structure Vue router-links to use "name" instead of urls 147119 - Bug_32932: Update router to use object references - agreements 147120 - Bug 32932: Update router to use name property for licences 147121 - Bug 32932: Update router to use name property for eholdings 147122 - Bug 32932: Update ermmain to use router name property 148115 - Bug 32932: (rebase) Rebased on top of bug 32991 Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug_32932: Update router to use object references - agreements error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue). error: could not build fake ancestor Patch failed at 0001 Bug_32932: Update router to use object references - agreements hint: Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug32932-Update-router-to-use-object-references----8WDpli.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #21 from Agustín Moyano <agustinmoyano@theke.io> --- I'll try to reapply your patches and make them work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147119|0 |1 is obsolete| | Attachment #147120|0 |1 is obsolete| | Attachment #147121|0 |1 is obsolete| | Attachment #147122|0 |1 is obsolete| | Attachment #148115|0 |1 is obsolete| | --- Comment #22 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148551&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #23 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148552&action=edit Bug 32932: Update router to use name property for licences As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #24 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148553&action=edit Bug 32932: Update router to use name property for eholdings As per previous commit for agreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #25 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148554&action=edit Bug 32932: Update ermmain to use router name property Updating the router links in the homepage as per previous commits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148551|0 |1 is obsolete| | Attachment #148552|0 |1 is obsolete| | Attachment #148553|0 |1 is obsolete| | Attachment #148554|0 |1 is obsolete| | --- Comment #26 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148558&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #27 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148559&action=edit Bug 32932: Update router to use name property for licences As per previous commit for agreements Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #28 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148560&action=edit Bug 32932: Update router to use name property for eholdings As per previous commit for agreements Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #29 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 148561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148561&action=edit Bug 32932: Update ermmain to use router name property Updating the router links in the homepage as per previous commits Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- - this.$router.push( - "/cgi-bin/koha/erm/eholdings/local/titles" - ) + this.$router.push({ + name: "EHoldingsLocalPackagesList", + }) You are replacing titles with packages here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am getting a blank page on /cgi-bin/koha/erm/eholdings/local/titles/2 Uncaught Error: No match for {"name":"EHoldingslocalPackagesList","params":{}} "local" vs "Local" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33417 [Bug 33417] Create one standard Toolbar component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #32 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 149210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149210&action=edit Bug 32932: (follow-up) Fix copy/paste bug in local titles form add and fix bad link definition in Main.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149210|0 |1 is obsolete| | --- Comment #33 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 149707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149707&action=edit Bug 32932: (follow-up) Fix copy/paste bug in local titles form add and fix bad link definition in Main.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148558|0 |1 is obsolete| | Attachment #148559|0 |1 is obsolete| | Attachment #148560|0 |1 is obsolete| | Attachment #148561|0 |1 is obsolete| | Attachment #149707|0 |1 is obsolete| | --- Comment #34 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 149709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149709&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #35 from Agustín Moyano <agustinmoyano@theke.io> --- squashed commits for rebase to apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Needs another rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149709|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149934&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149934|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149935&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Functionality all tests out good, QA scripts are happy :) Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149935|0 |1 is obsolete| | --- Comment #40 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 151529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151529&action=edit Bug 32932: Update router to use object references - agreements This patch updates the Vue files for ERM to use router object links rather than urls - this will make it much simpler to maintain the router if urls need to be updated. This first patch only updates the files in the agreements section of ERM as a first step to introduce the topic for discussion. Test plan: 1) Apply patch 2) Navigate to the Agreements section of ERM and click on different navigation links/buttons 3) The links/buttons should all work as normal 4) Review the code to see that the component files now refer back to the router using objects rather than url strings Signed-off-by: Agustin Moyano <agustinmoyano@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think we need a test to prevent regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The current test suite does a lot of navigation using .click() events - this should cover the router functionality for those routes/links. Do we just need a test that tests the routes that aren't currently included in existing cypress tests or are you thinking of a different testing method? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was more thinking: how do we make sure future changes won't introduce non-named URLs in ERM or even other vue files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #45 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #44)
I was more thinking: how do we make sure future changes won't introduce non-named URLs in ERM or even other vue files?
Might be worth seeing if there's a way of using ESLint to check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33941 [Bug 33941] EBSCO Packages filter failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- ESLint could work if we create a custom rule, or we'd need to add something into the pre-commit hook to check Vue files for urls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch makes Titles_spec.ts fail: "ReferenceError: resource_id is not defined" in "Show title". Can you have a look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #48 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 152231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152231&action=edit Bug 32932: Fix resource_id param for EHoldingsLocalResourcesShow Caught by cypress tests "ReferenceError: resource_id is not defined" in "Show title". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #47)
This patch makes Titles_spec.ts fail: "ReferenceError: resource_id is not defined" in "Show title".
Can you have a look please?
Don't worry, I fixed it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.01 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.01 |23.11.00,23.05.01,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |tomascohen@gmail.com --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The follow-up has been pushed to master, 23.05 and 22.11. Removing the 'additional_work_needed' flag, and closing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32932 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org