https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59490&action=edit Bug 17980: Fix wrong call to ModZebra in AddAuthority (affects Elastic Search users) The ModZebra call in AddAuthority incorrectly passes five parameters to ModZebra including $oldRecord. This makes the last parameter (the new record) being ignored !! A closer inspection of ModZebra reveals that this only affects installs using Elastic Search. The record parameter is ignored when you still use Zebra. Note: Keep in mind that AddAuthority is being used in adding as well as modifying authority records. This patch is part of a larger effort to make improvements in this area and will not be last one. Please help to get this further (see bug 17908). Trivial fix. Test plan: [1] If you use Elastic Search, verify that the new authority record is being indexed, not the old one. [2] If you do not use Elastic Search, add or modify an authority and search for this change in Authority (Search entire record). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz, | |nick@bywatersolutions.com --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Chris or Nick: could one of you please confirm the Elastic Search side? Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Actually, the Elastic Search problem is larger than this: Look at ModZebra itself: if ( $op eq 'specialUpdate' ) { unless ($record) { $record = GetMarcBiblio($biblionumber, 1); } my $records = [$record]; $indexer->update_index_background( [$biblionumber], [$record] ); } This code is wrong in case you call ModZebra for an authority ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59491&action=edit Bug 17980: Corresponding fix in DelAuthority The call to ModZebra here does not need more than three parameters. Same for Zebra and Elastic Search. Note: On omnibus bug 17908 a few more fixes are coming on this subject of deleting authorities. Test plan: [1] Delete an authority. [2] Search for it in the Authority module. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix wrong call to ModZebra |Fix wrong calls to ModZebra |in AddAuthority (affects |in AuthorityMarc |Elastic Search users) | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17980 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes.