[Bug 28608] New: Creating a biblio record leads to item creation even if framework has no items field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Bug ID: 28608 Summary: Creating a biblio record leads to item creation even if framework has no items field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 122230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122230&action=edit Bug 28608: Creating a biblio record must not lead to item creation when framework has no items field Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. This patch adds a condition next to items edition permission to have only one save button when framework has no items field. 1) Create a biblio framework without items field (952 in MARC21, 995 in UNIMARC) 2) Create a biblio record with this framework 3) Click on "Save" => Without patch you see items creation page (with no inputs in form) => With patch you see record details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- We may hide other things when framework has no items field. Maybe we will create a method has_items() in Koha::BiblioFramework -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #3 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122254&action=edit Issue #6 - list of bugs applied must be global https://bugs.koha-community.org/show_bug.cgi?id=28608 Signed-off-by: hakam <hakam@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak@inLibro.com Attachment #122254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122230|0 |1 is obsolete| | --- Comment #4 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122255&action=edit Bug 28608: Creating a biblio record must not lead to item creation when framework has no items field Some framework for biblio records have no items field (952 in MARC21, 995 in UNIMARC). Records can not have items for example a serial article. In this case creating a record should not lead to item creation. This patch adds a condition next to items edition permission to have only one save button when framework has no items field. 1) Create a biblio framework without items field (952 in MARC21, 995 in UNIMARC) 2) Create a biblio record with this framework 3) Click on "Save" => Without patch you see items creation page (with no inputs in form) => With patch you see record details page Signed-off-by: hakam <hakam@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Interesting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak@inLibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Processing files before patches Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt line 896. |========================>| 2 / 2 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt line 896. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)
Processing files before patches Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ addbiblio.tt line 896. |========================>| 2 / 2 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ addbiblio.tt line 896.
[% IF ( BIG_LOOP.size > 1 ) %] ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing. There might be something wrong here.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- =head2 GetMarcFromKohaField ( $field,$subfield ) = GetMarcFromKohaField( $kohafield ); @fields = GetMarcFromKohaField( $kohafield ); $field = GetMarcFromKohaField( $kohafield ); Returns the MARC fields & subfields mapped to $kohafield. Since the Default framework is considered as authoritative for such mappings, the former frameworkcode parameter is obsoleted. In list context all mappings are returned; there can be multiple mappings. Note that in the above example you could miss a second mappings in the first call. In scalar context only the field tag of the first mapping is returned. =cut -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +( $itemtag, $itemsubfield ) = GetMarcFromKohaField( "items.itemnumber" ); Your call here does not look at the specific itemnumber field in that framework since kohafields are looked up in the Default framework. This is already the case in a few Koha versions. I know since I was involved in that dev ;) So your framework may not have an itemnumber field, but if the Default has, then you can still add an item. You need to think of a solution in some other way? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28992 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oups indeed. Will have another look on it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Assignee|fridolin.somers@biblibre.co |baptiste.wojtkowski@biblibr |m |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org