http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10833 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28481&action=edit Bug 12315: Advanced notices are duplicated and not sent to the right patron Bug 10833 introduced a variable loop but does not reset it every iteration. So the first patron receives correct letters, but the followings received all the previous ones AND his letters. Test plan: 0/ Delete the content of the message_queue table. 1/ Define advanced notices sent 2 days in advance for 2 patrons. 2/ Check 1 item out for each one and specify a due date today + 2 days. 3/ Launch the advance_notices.pl script. 4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for each patron. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28481|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28489&action=edit [SIGNED-OFF] Bug 12315: Advanced notices are duplicated and not sent to the right patron Bug 10833 introduced a variable loop but does not reset it every iteration. So the first patron receives correct letters, but the followings received all the previous ones AND his letters. Test plan: 0/ Delete the content of the message_queue table. 1/ Define advanced notices sent 2 days in advance for 2 patrons. 2/ Check 1 item out for each one and specify a due date today + 2 days. 3/ Launch the advance_notices.pl script. 4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for each patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work well, no errors. Tested following test plan, printing on screen or saving into db, 3 messages before, 2 after (advance_notices.pl -v -n -m 2 -c) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com QA Contact|testopia@bugs.koha-communit |gmcharlt@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28489|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28497&action=edit Bug 12315: fix sending of duplicate advanced notices (and sending advanced notices to wrong patron) Bug 10833 introduced a variable loop but does not reset it every iteration. So the first patron receives correct letters, but the following ones received all the previous ones as well as their own notices Test plan: 0/ Delete the content of the message_queue table. 1/ Define advanced notices sent 2 days in advance for 2 patrons. 2/ Check 1 item out for each one and specify a due date today + 2 days. 3/ Launch the advance_notices.pl script. 4/ Before this patch, you got 3 notices. Now, you get 2 notices, 1 for each patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work well, no errors. Tested following test plan, printing on screen or saving into db, 3 messages before, 2 after (advance_notices.pl -v -n -m 2 -c) Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Thanks for this great fix! It saved us a lot of trouble, too bad this didn't extend to the digest subsystem as well. I provided a followup as a separate Bug 12396. Take care! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolyn.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Bug 10833 is only since 3.16 so this patch is not needed for 3.14 and below. I set as fixed -- You are receiving this mail because: You are watching all bug changes.