https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Mika <mikasmith@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57786|0 |1 is obsolete| | --- Comment #2 from Mika <mikasmith@catalyst.net.nz> --- Created attachment 57810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57810&action=edit Bug 17689: Add the Koha::Issue->is_overdue method This patch adds a new method Koha::Issue->is_overdue and provide tests to cover it. The goal is to behave like GetItemIssues set the 'overdue' flag to issues. I don't understand why the existing GetItemIssues truncate dates to minutes, so I did not recreate this behavior. Test plan: prove t/db_dependent/Koha/Issues.t should return green Signed-off-by: Mika Smith <mikasmith@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57810|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57864&action=edit Bug 17689: Add the Koha::Issue->is_overdue method This patch adds a new method Koha::Issue->is_overdue and provide tests to cover it. The goal is to behave like GetItemIssues set the 'overdue' flag to issues. I don't understand why the existing GetItemIssues truncate dates to minutes, so I did not recreate this behavior. Test plan: prove t/db_dependent/Koha/Issues.t should return green Signed-off-by: Mika Smith <mikasmith@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57864|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58293&action=edit Bug 17689: Add the Koha::Checkout->is_overdue method This patch adds a new method Koha::Checkout->is_overdue and provide tests to cover it. The goal is to behave like GetItemIssues set the 'overdue' flag to issues. I don't understand why the existing GetItemIssues truncate dates to minutes, so I did not recreate this behavior. Test plan: prove t/db_dependent/Koha/Checkouts.t should return green Signed-off-by: Mika Smith <mikasmith@catalyst.net.nz> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the |Add the |Koha::Issue->is_overdue |Koha::Checkout->is_overdue |method |method CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.