[Bug 32003] New: Accessibility: Order search results has to h1 headings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Bug ID: 32003 Summary: Accessibility: Order search results has to h1 headings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When using the order search in acq, there are 2 h1 leve headings directly below one another with no content in between. Order search Search results Maybe we should just have one: Order search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 144924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144924&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144924|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144945&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks, Lucas :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Page section added by Bug 32616 already. Heading still needs to be fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: Order search |Accessibility: Order search |results has to h1 headings |results has two h1 headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144945|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147675&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147675|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 148148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148148&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148148|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 148644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148644&action=edit Bug 32003: Add page-section to order search results and fix heading hierarchy This adds a page-section to the order search results and moves the former second h1 heading 'search results' to a h2 heading below 'Order search', so we have a proper hierarchy In acquisitions: * Make sure you have an order with at least one order line * Do an empty orders search * Verify there are 2 h1 headings on the page and the results table doesn't have a white background * Apply patch * Verify the results list now has a white background and the second now smaller heading has been moved into this area Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org