https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |major --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://lists.katipo.co.nz/pipermail/koha/2017-January/047102.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Clint, could to try and recreate on a sandbox? What is the line 472 of circ/circulation.pl? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- as a temporary workaround, I put this in the intranetuserjs syspref : $('#mainform').submit(function(event){ if ( ! $('#barcode').val().length ) { event.preventDefault(); window.location.replace("/cgi-bin/koha/circ/circulation.pl"); } }); Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I tested against master (on a vbox) and at first sight, it seems OK. At least, no error, even if we set a permission to the patron. But the issue is real on 3.22 (our preprod version is 3.22.12). A parameter is really passed to circulation.pl (probably in post method) and I can now assert that this parameter is the flags value (?!!). Don't ask me how it is but it is. In the first comment from ClintD, the "1" string corresponds with no doubt to superlibrarian flags value. To reproduce, you can try that. 1) take a patron without any permissions and check that the error issue does not already occurs. 2) set a permission to him. Tick for instance the "reservesforothers" one (flags value = 64) 3) go back to checkout tab, put your cursor in the barcode input and press Enter : you will get this : Can't use string ("64") as a HASH ref while "strict refs".... 4) remove the permission 5) redo step 3. you will now get this : Can't use string ("0") as a HASH ref while "strict refs".... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|16.05 |16.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60647&action=edit Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable is reset but $borrower. In 16.11.x and before that causes the app to crash, because $borrower->{flags} is set to a hashref by GetMemberDetails, if $borrowernumber is set. This case is better handled in master (17.05) but side-effects could happen: if $borrowernumber is reset, $borrower should be reset too. The way to drive this behaviour is terrible and lot of things should be done to clean this area. This patch is a quick and easy fix to make it backportable easily. Test plan: On master, no change expected On 16.11 and before: 0. Set CircAutoPrintQuickSlip=clear screen 1. Create a new patron 2. Set permission for this patron to 'reservesforothers' (or something else). 3. Go on the circulation tab 4. Do not fill the barcode input and submit => Without this patch you will get an error Can't use string ("64") as a HASH ref while "strict refs".... => With this patch apply you will get a blank screen (expected behaviour). I would recommend to test this patch with the other value of CircAutoPrintQuickSlip as well -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Passed QA --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Can't say that terrible hacks look good, but at least we could move this patch to the queue of Katrin.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please ping me on IRC about patches for 16.11.x - almost missed this! :) This patch has been pushed to 16.11.x and will be in 16.11.07. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18022 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #14 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.