[Bug 40990] New: Checkout override allowed without permissions when item has circulation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Bug ID: 40990 Summary: Checkout override allowed without permissions when item has circulation alert Change sponsored?: --- Product: Koha Version: 25.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: maxeinergl@gcc.edu QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Koha will allow staff who do not have force_checkout permissions to check out items beyond the maximum number per type allowed if the item has a circulation alert. In this case a warning is offered but staff can click to continue with the checkout. This behavior is different than when items do not have the circulation alert ; in that case the same staff hit a hard block and cannot override the limitation. This may be related to bug 38540. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38540 CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #1 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Clarifying this - by "circulation alert" I mean the item has content in items.materials. (Thanks to the new debug control, I realize we have local coding to rename "Materials specified" as a circulation alert :-)). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Severity|trivial |normal Version|25.05 |Main --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm upping the severity here from "trivial" to "normal" and setting the version to main, having confirmed this issue exists in current main. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Recreated in current main: 1. Create or find a staff user with circulate_remaining_permissions and staffaccess 2. Set the "Current checkouts allowed" circ rule to 1 3. Find a patron and check out 1 item. 4. Now, using the user from step 1, attempt a 2nd checkout. You cannot do it. 5. Now add a materials specified note to the 952$3 6. Attempt the checkout again. See the popup related to the 952$3, click 'Yes, check out' 7. The item is checked out -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- The template is rendering the 'Yes, check out' any time there is a mats specified not. This is effectively skipping all other overrides, Clicking it immediately makes the checkout because the <input type="hidden" name="issueconfirmed" value="1"> is passed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 212235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212235&action=edit Bug 40990: Prevent ADDITIONAL_MATERIALS from bypassing force_checkout To test: 1. Create or find a staff user with circulate_remaining_permissions and staffaccess 2. Set the "Current checkouts allowed" circ rule to 1 3. Find a patron and check out 1 item. 4. Now, using the user from step 1, attempt a 2nd checkout. You cannot do it. 5. Now add a materials specified note to the 952$3 6. Attempt the checkout again. See the popup related to the 952$3, click 'Yes, check out' 7. The item is checked out 8. APPLY PATCH, restart_all 9. Trying everything again, the checkout should be blocked at step 6. You won't see the 952$3 popup, only the popup telling you that you cannot do this checkout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 38540 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #212235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #7 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Created attachment 212236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212236&action=edit Bug 40990: Prevent ADDITIONAL_MATERIALS from bypassing force_checkout To test: 1. Create or find a staff user with circulate_remaining_permissions and staffaccess 2. Set the "Current checkouts allowed" circ rule to 1 3. Find a patron and check out 1 item. 4. Now, using the user from step 1, attempt a 2nd checkout. You cannot do it. 5. Now add a materials specified note to the 952$3 6. Attempt the checkout again. See the popup related to the 952$3, click 'Yes, check out' 7. The item is checked out 8. APPLY PATCH, restart_all 9. Trying everything again, the checkout should be blocked at step 6. You won't see the 952$3 popup, only the popup telling you that you cannot do this checkout. Signed-off-by: Gretchen Maxeiner <maxeinergl@gcc.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Signed off using a sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40990 --- Comment #9 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- Everything works according to the test plan. I also tested on the issue from bug 38540 (when fines are over the NoIssuesCharge amount) and that problem is also taken care of. Thank you Lucas. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org