[Bug 33491] New: EBSCO Packages - Add new agreement UI has some issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Bug ID: 33491 Summary: EBSCO Packages - Add new agreement UI has some issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha@gmail.com Reporter: pedro.amorim@ptfs-europe.com CC: jonathan.druart+koha@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com Depends on: 33483 Created attachment 149453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149453&action=edit screenshot of UI Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 [Bug 33483] Cannot link EBSCO's package with local agreement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- * There's a problem with the "filter by mine" filter at the top * There's a problem with the table not going full width, this is not as trivial as the fix I did for bug 33066 here https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=33066&attachment=149183 Can't just move the table out of the <fieldset> since it's a nested component. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149474&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch is not ideal but it's fixing the main problems. Pedro, do you think it's acceptable as it, at least for backport maybe then we see how we can improve this view later? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- It doesn't fix the "show mine only" being punted to the left, this is because it's getting a float:left also from being a child of <fieldset> (which is also causing the table to not be full width). The problem is <EHoldingsPackageAgreements> sits inside a <fieldset> in EHoldingsEBSCOPackagesShow.vue. Then, in EHoldingsEBSCOPackageAgreements.vue we're opening the modal that has <AgreementsList> inside it, but that modal is already a child of the aforementioned <fieldset> so it's inheriting its style unintendendly. There is also another problem: the modal needs a overflow (and perhaps a max-height?). If we have many agreements created, the modal overflows the screen and doesn't let the user scroll vertically. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149474|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149778&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Pedro Amorim from comment #4)
It doesn't fix the "show mine only" being punted to the left, this is because it's getting a float:left also from being a child of <fieldset> (which is also causing the table to not be full width).
The problem is <EHoldingsPackageAgreements> sits inside a <fieldset> in EHoldingsEBSCOPackagesShow.vue.
Then, in EHoldingsEBSCOPackageAgreements.vue we're opening the modal that has <AgreementsList> inside it, but that modal is already a child of the aforementioned <fieldset> so it's inheriting its style unintendendly.
Fixed in the last version of the patch.
There is also another problem: the modal needs a overflow (and perhaps a max-height?). If we have many agreements created, the modal overflows the screen and doesn't let the user scroll vertically.
I would suggest to deal with that on a separate bug. I think we need a separate component for modal, in which we will deal with this issue (we use .modal in a couple of places already) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149778|0 |1 is obsolete| | --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149823&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149823|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149853&action=edit Bug 33491: Fix UI issues in EHoldingsEBSCOPackageAgreements Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is certainly an improvement, Passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 149924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149924&action=edit comparison Top picture is the header in agreements list before the patch, bottom picture is after the patch. This CSS in this patch is being applied in agreements list unintentionally. .filters input[type="checkbox"] { margin-left: 0 !important; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150505&action=edit Bug 33491: Do not apply style to agreement list view We removed the 'scoped' attribute and so the style rules added in the previous patch were applied to the agreement list view. Why is 'scoped' not working is the main question here (?) but adding a more specific selector to aim only the component (AgreementsList) from the modal is a quick solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Pedro Amorim from comment #11)
Created attachment 149924 [details] comparison
Top picture is the header in agreements list before the patch, bottom picture is after the patch.
This CSS in this patch is being applied in agreements list unintentionally.
.filters input[type="checkbox"] { margin-left: 0 !important; }
This patch is fixing the problem. Do you have something better to suggest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150505|0 |1 is obsolete| | --- Comment #14 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 150518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150518&action=edit Bug 33491: Do not apply style to agreement list view We removed the 'scoped' attribute and so the style rules added in the previous patch were applied to the agreement list view. Why is 'scoped' not working is the main question here (?) but adding a more specific selector to aim only the component (AgreementsList) from the modal is a quick solution. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
Why is 'scoped' not working is the main question here
As Pedro pointed to me, it is actually working as expected: style rules are defined in EHoldingsEBSCOPackageAgreements and the table is in AgreementList. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is another problem: https://snipboard.io/Odhrai.jpg The .modal rule should apply to the modal of the EHoldingsEBSCOPackageAgreements component only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 150564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150564&action=edit Bug 33491: Add a more specific class for the modal We don't want to apply these CSS rules to other modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #18 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@ptfs-europe.com Status|Pushed to stable |ASSIGNED --- Comment #19 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- PLEASE IGNORE THE ABOVE, NOT PUSHED TO STABLE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #17)
Created attachment 150564 [details] [review] Bug 33491: Add a more specific class for the modal
We don't want to apply these CSS rules to other modals
Pedro, should we go with this patch and see if we can do better on a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch still missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #23)
Last patch still missing.
Sorry, I merged the last two patches. Don't remember how/why. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- *** Bug 35132 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33491 Bug 33491 depends on bug 33483, which changed state. Bug 33483 Summary: Cannot link EBSCO's package with local agreement https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33483 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org