[Bug 17650] New: Create the option to save the cover with the uploaded files.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Bug ID: 17650 Summary: Create the option to save the cover with the uploaded files. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: rsantellan@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Create the option to save the uploaded cover files with the rest of the files. Removing them from saving on the DB and save them on the koha uploads directory. Giving the implementation of creating cache miniatures for using them. There must be an option to enable this feature or not for backward compability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Do you plan to add records too in uploaded_files table ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Rodrigo Santellan <rsantellan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |16.05 --- Comment #2 from Rodrigo Santellan <rsantellan@gmail.com> --- In the current flow the files are added on the uploaded_files tables. The only difference is that they are with permanent = 0 instead of permanent = 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Rodrigo Santellan from comment #2)
In the current flow the files are added on the uploaded_files tables. The only difference is that they are with permanent = 0 instead of permanent = 1
The permanent=0 files are stored in another file location (/tmp) and are meant to be removed after some defined number of days (work in progress). Just need to add a cron job for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #4 from Rodrigo Santellan <rsantellan@gmail.com> --- Created attachment 57596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57596&action=edit Search a cover image. Final look for re utilizing cover images. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #5 from Rodrigo Santellan <rsantellan@gmail.com> --- I added an image to what I want to achieve. The main goal is to re utilize the same image for different biblios without adding them multiple times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #6 from Rodrigo Santellan <rsantellan@gmail.com> --- Created attachment 57598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57598&action=edit Bug 17650 - Create the option to save the cover with the uploaded files. Create the option to save the uploaded cover files with the rest of the files. Removing them from saving on the DB and save them on the koha uploads directory. Giving the implementation of creating cache miniatures for using them. Added an option on System Preferences to enable this new feature: SaveCoverOnDisk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #7 from Rodrigo Santellan <rsantellan@gmail.com> --- The Images.t should pass as usual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Rodrigo Santellan <rsantellan@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- tools/upload-file.pl Remove Dumper and warn please Also from tools/upload-cover-image.pl and file-search INSERT INTO biblioimages (biblionumber, mimetype, imagefile, thumbnail, uploadedfileid) The mix of upload and biblioimages like this does not look good to me. Isn't this just a new type of cover images to be triggered by a new pref somewhere else? Discussion ?? In _retrieve_thumbs_images you seem to copy/save the file somewhere else outside the uploads dir ? tools/file-search.pl Converted to new plugin style (Bug 13437) ??? $debug or $debug = $input->param('debug') || 0; ??? use warnings; no warnings 'redefine'; # otherwise loading up multiple plugins fills the log with subroutine redefine warnings Hmm Did you test this under Plack too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 --- Comment #9 from Rodrigo Santellan <rsantellan@gmail.com> --- Yes I tested under plack and is working. I save on /tmp the thumbnail of the image to not process it multiple times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Eric <eric.gosselin.5@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |eric.gosselin.5@gmail.com --- Comment #10 from Eric <eric.gosselin.5@gmail.com> --- Patch didn't apply in the sandbox. Some problems occurred applying patches from bug 17650: <h1>Something went wrong !</h1>Applying: Bug 17650 - Create the option to save the cover with the uploaded files. .git/rebase-apply/patch:69: trailing whitespace. ->png(), ); .git/rebase-apply/patch:73: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. ->{'imagefile'} = ; .git/rebase-apply/patch:157: trailing whitespace. ALTER TABLE .git/rebase-apply/patch:159: trailing whitespace. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57598|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 80745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80745&action=edit Bug 17650 - Create the option to save the cover with the uploaded files. Create the option to save the uploaded cover files with the rest of the files. Removing them from saving on the DB and save them on the koha uploads directory. Giving the implementation of creating cache miniatures for using them. Added an option on System Preferences to enable this new feature: SaveCoverOnDisk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Hopefully rescued correctly. The move of javascript to the bottom broke the application. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |rsantellan@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold@dgiinc.com --- Comment #13 from Cori Lynn Arnold <carnold@dgiinc.com> --- Can I get some test steps for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie --- Comment #14 from Holly <hc@interleaf.ie> --- Hi, I was just wondering if someone could provide some test steps for this please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- The patch applies fine (wow), and I have one suggestion right off the bat: The system preference should be worded and structured in a way that it is a sentence. Instead of: [Yes/No] Save the covers on the the hard disk instead of the database. It should be something like: Save cover images on the [hard disk/database]. Would it be clearer to say "server file system" instead of "hard disk?" Could people be confused that it referred to their own hard disk? I ran into a problem, though, as soon as I navigated to the 'Upload local cover image' page: Can't locate Koha/Upload.pm in @INC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com --- Comment #16 from Blou <philippe.blouin@inlibro.com> --- This functionality would interest us. We're trying to reduce the imprint of biblioimages on our database size. Is there a reason the QA could already forewarn us about that this idea (moving biblioimages outside the DB) would gain no traction? Not sure if the current implementation is the right way, but we'd add a script to move the current biblioimages out, as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create the option to save |Create the option to save |the cover with the uploaded |local cover images outside |files. |the database Version|16.05 |master CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Is there a reason the QA could already forewarn us about that this idea (moving biblioimages outside the DB) would gain no traction?
I think it would make sense to have this at least as an option. Not sure if or how existing installations could be switched over. Adding some more CC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17650 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org