[Bug 19840] New: Patron note is not displayed on checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Bug ID: 19840 Summary: Patron note is not displayed on checkin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 14224 If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18276 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This bug may have been caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69923&action=edit Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 69924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69924&action=edit Bug 19840: And avoid XSS... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19798 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69923|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70054&action=edit Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69924|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70055&action=edit Bug 19840: And avoid XSS... Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70054|0 |1 is obsolete| | Attachment #70055|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70088&action=edit Bug 19840: Fix - display patron note on checkin If a patron let a note on the checkout (AllowCheckoutNotes), it is supposed to be displayed when checked in. Test plan: 1/ Enable AllowCheckoutNotes 2/ Check an item out 3/ At the opac let a note on the checkout 4/ Check the item in => With this patch applied you should see the notes displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 70089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70089&action=edit Bug 19840: And avoid XSS... Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19840 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 18276 is not in 17.05.x but is this bug needed for it anyway ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org