[Bug 11131] New: Authority search does not display summary while searching by all auth types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Bug ID: 11131 Summary: Authority search does not display summary while searching by all auth types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org To reproduce: - go on authorities/authorities-home.pl - search 'hugo' by authtype author - results are displayed with summary - now select the "all authority types" entry and search "hugo": the results but without the summary -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22358&action=edit Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-11-07 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') [1;32mOK[0m C4/AuthoritiesMarc.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz When did the bot|2013-11-07 00:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22358|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23840&action=edit Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search <something> by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23840|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23858&action=edit [PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types The summary is built using the authtypecode selected from the interface. So when a search is launch on all auth types, the summary is not correctly built by the BuildSummary routine. It should get the authtypecode from the authority (call to GetAuthTypeCode). To test: 1/ go to authorities/authorities-home.pl 2/ search <something> by authtype personal name 3/ results are displayed with summary 4/ now select the default entry and search again the results display but without the summary 5/ apply the patch 6/ search default again, now summary shows Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with a UNIMARC database, works as described. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.3. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org