https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|gmcharlt@gmail.com |josef.moravec@gmail.com Depends on| |17397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17397 [Bug 17397] Show name of librarian who created circulation message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 57223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57223&action=edit Bug 17558: Add more tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Strange, my koha-qa says it's OK... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- This is a(In reply to Bernardo Gonzalez Kriegel from comment #3)

Hi, I got an error with koha-qa script

FAIL t/db_dependent/Koha/Patron/Messages.t OK critic OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Use of uninitialized value $_[0] in lc

Don't know the cause.

This is a problem from old Cache.pm in Debian and maybe in some version of Ubuntu The old module 2.04

sub Canonicalize_Expiration_Time { my $timespec = lc($_[0]) or return undef;

my $time;

And the update module 2.11:

sub Canonicalize_Expiration_Time { my $timespec;

my $timespec_param = shift(@_); if (! $timespec_param) { return undef; } $timespec = lc($timespec_param);

my $time;

Regards -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57223|0 |1 is obsolete| | --- Comment #8 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 57431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57431&action=edit [SIGNED-OFF]Bug 17558: Add more tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests pass successfuly -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my $patron = $builder->build( { source => 'Borrower', values => { branchcode => $library->{branchcode} } } ); +my $patron_2 = Koha::Patrons->search->next; Wouldn't it be more consistent to use TestBuilder for both patrons. This is confusing and might give unexpected results depending on patrons present? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #9)

my $patron = $builder->build( { source => 'Borrower', values => { branchcode => $library->{branchcode} } } ); +my $patron_2 = Koha::Patrons->search->next;

Wouldn't it be more consistent to use TestBuilder for both patrons. This is confusing and might give unexpected results depending on patrons present?

You are right, I've attached a followup patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 57458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57458&action=edit Bug 17558: Add more tests Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> All tests pass successfuly Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17558 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Mason James <mtj@kohaaloha.com> --- (In reply to Kyle M Hall from comment #16)

Pushed to master for 16.11, thanks Josef!

blocked by DB changes, passing for 16.05 -- You are receiving this mail because: You are watching all bug changes.