[Bug 18437] New: Acquisitions fund edit repair
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Bug ID: 18437 Summary: Acquisitions fund edit repair Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org While editing a fund, if there is no owner and you select an owner, the owner does not appear until you save the edit and edit it again. Also, when adding users, the selection tool is not checking if the user selected is already added. Links next to owner and users should be converted to buttons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cbrannon@cdalibrary.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62185&action=edit Bug 18437: Repair links & testing / Add buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat steps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Wanted to test but patch does not apply on current master: fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62185|0 |1 is obsolete| | --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62341&action=edit Bug 18437: Repair links & testing / Add buttons (REBASED) To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat steps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #4 from Marc Véron <veron@veron.ch> --- Sorry, I can still not apply: Wende an: Bug 18437: Repair links & testing / Add buttons fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt). Dem Repository fehlen notwendige Blobs um auf einen 3-Wege-Merge zurückzufallen. Kann nicht zu 3-Wege-Merge zurückfallen. (Necessary blobs missing, can not fall back to 3-way-merge) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62534&action=edit [BUG 18437] Fix selects / change links to buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62534|0 |1 is obsolete| | --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62536&action=edit [BUG 18437] Fix selects / change links to buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- Okay, I think I got it this time. Still figuring out all the quirks with git, so thank you for your patience! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #8 from Marc Véron <veron@veron.ch> --- It works as described, but while testing I found two issues: Owners: - If no owner is set, I see next 'Owner:' the text 'No owner', the 'Select' button and the 'Remove' butten. Remove makes no sense here. - Remove button has no waste bin icon (but for users it has). Users: - If I add a new user I can not remove again. (After submitting the page, removing works). Not related to this bug, but for the records: - On the select screen, th language selector hides the results (especially on narrow screens). Is a language selector necessary here? - On the select screen, if I accidentally click on the patron's name, their detail screen is displayed in the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13835 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62536|0 |1 is obsolete| | --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62560&action=edit [BUG 18437] Fix selects / change links to buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marc Véron from comment #8)
It works as described, but while testing I found two issues:
Owners: - If no owner is set, I see next 'Owner:' the text 'No owner', the 'Select' button and the 'Remove' butten. Remove makes no sense here. - Remove button has no waste bin icon (but for users it has).
Users: - If I add a new user I can not remove again. (After submitting the page, removing works).
Not related to this bug, but for the records: - On the select screen, th language selector hides the results (especially on narrow screens). Is a language selector necessary here? - On the select screen, if I accidentally click on the patron's name, their detail screen is displayed in the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.)
Removed remove button when there is no owner (NEW FUNCTION). I was having trouble with this before, and it was not one of the issues I had originally focused on. Fixed the problem with removing a user you just added. Other issues, yes, I agree about the other issues. Needs to be in a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #11 from Marc Véron <veron@veron.ch> --- (In reply to Christopher Brannon from comment #10)
(In reply to Marc Véron from comment #8) (...)
Not related to this bug, but for the records: - On the select screen, th language selector hides the results (especially on narrow screens). Is a language selector necessary here? (...)
Other issues, yes, I agree about the other issues. Needs to be in a new bug.
For the language menu see Bug 13835 with status NSO :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #12 from Marc Véron <veron@veron.ch> --- Works great now. But sorry, QA tools complain: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 528 I think it is related to: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolk... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- Ugh! I was contemplating that, but this was so much more elegant. :/ Okay. I'll have it fixed in a moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62560|0 |1 is obsolete| | --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 62561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62561&action=edit [BUG 18437] Fix selects / change links to buttons To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Marc Véron from comment #12)
Works great now.
But sorry, QA tools complain:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt FAIL tt_valid lines 528
I think it is related to: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1: _Template_Toolkit_markup_inside_HTML
Okay. Give it a whirl again. (Crossing fingers) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18480 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #16 from Marc Véron <veron@veron.ch> --- (In reply to Christopher Brannon from comment #10)
(In reply to Marc Véron from comment #8) (...)
Not related to this bug, but for the records: - On the select screen, th language selector hides the results (especially on narrow screens). Is a language selector necessary here? - On the select screen, if I accidentally click on the patron's name, their detail screen is displayed in the pop up. No way to get back to the selection screen. (You have to close the pop up and start over adding.) (...) Other issues, yes, I agree about the other issues. Needs to be in a new bug.
See Bug 18480 (NSO) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Lauren <ldenny76@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldenny76@gmail.com Status|Needs Signoff |Signed Off --- Comment #17 from Lauren <ldenny76@gmail.com> --- We tested this bug at the KohaCon 2017 and it works however we were not able to sign off. We got this message "It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch." Lauren & Maricon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62561|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 66772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66772&action=edit Bug 18437 - Acquisitions fund edit repair To Test: 1) Create fund. 2) Select owner. 3) Select user. 4) Select same user again. 5) Note owner does not show unless you save the changes and edit the fund again. 6) Note user can be added multiple times. 7) Apply patch. 8) Repeat stepps 1-4. 9) Note owner now shows first time. 10) Note user cannot be added multiple times. 11) Note links by owner and users have been changed to buttons. 12) Note "No owner" and "No users" messages have been added when there are none. https://bugs.koha-community.org/show_bug.cgi?id=18437 Signed-off-by: Lauren Denny <ldenny76@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- "No owner" isn't translatable in the javascript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for catching the translation issue Kyle. There is another here: $("#budget_users").prepend('<li id="user_none">No users</li>'); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 --- Comment #21 from Christopher Brannon <cbrannon@cdalibrary.org> --- Reworking - owner shows as null/null when added, and doesn't show at all after saving and editing fund again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18437 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #22 from Christopher Brannon <cbrannon@cdalibrary.org> --- Shows null, null if no names in account. This is very insignificant. Everything else of concern has already been addressed. Abandoning this bug. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org