[Bug 15947] New: SIPILS.t should be moved to t/db_dependent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Bug ID: 15947 Summary: SIPILS.t should be moved to t/db_dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: gmcharlt@gmail.com QA Contact: gmcharlt@gmail.com t/SIPILS.t, which was added in bug 15479, requires an active koha-conf.xml to pass, and consequently should be moved to t/db_dependent. This required patching around in order to build the 3.22.4 Debian packages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 48511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48511&action=edit Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48511|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 48524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48524&action=edit [SIGNED OFF] Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 48538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48538&action=edit Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton <gmcharlt@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 [Bug 15956] Rearranging some SIP unit tests (test without SIP server) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Will add a follow-up under new report: bug 15956. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org