[Bug 31775] New: Show opac_info of single library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Bug ID: 31775 Summary: Show opac_info of single library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org When there is only one library, the library list is skipped, but since opac-main does not pass a branch code, you won't see branch info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 [Bug 29144] Move branches.opac_info to AdditionalContents allowing multi language -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141824&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141825&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I had a go at testing, but struggled to notice any difference - except that for a single library, the library name is linked. No additional information is displayed on the linked page (even if all the library information fields are filling in). If this is what is expected, I'm happy to sign off. Testing notes (using koha-testing-docker): - Needed to batch modify patrons to change their library to the one kept (possibly could have just deleted all patrons). - Needed to batch modify items for all libraries not kept so that their home library and current library changed to the library kept. - Not sure how to make a library not publicly accessible, is there some other system preference to change? . Changing an existing library: get message "An error occurred when updating this library. Perhaps it already exists." . Creating a new library - even if you change public to "No", it saves as public with "Yes". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #3)
I had a go at testing, but struggled to notice any difference - except that for a single library, the library name is linked. No additional information is displayed on the linked page (even if all the library information fields are filling in).
If this is what is expected, I'm happy to sign off.
Thx for testing, David. You are correct: my test plan could be more detailed. What we need to do also, is add the opac_info information for a branch via Additional Contents, html cust., OpacLibraryInfo location. For one library you should see the full info page at once. For more libraries you should see the list first. Deleting a library should not be needed. Just hiding it via the public flag. I will check if you found a bug there too.. Will comment on a few other points still. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31784 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #3)
Testing notes (using koha-testing-docker):
- Needed to batch modify patrons to change their library to the one kept (possibly could have just deleted all patrons). Should not be needed when you hide a branch.
- Needed to batch modify items for all libraries not kept so that their home library and current library changed to the library kept. Same. Not really needed.
- Not sure how to make a library not publicly accessible, is there some other system preference to change? Go to Admin. Libraries. Edit library. Change public.
. Changing an existing library: get message "An error occurred when updating this library. Perhaps it already exists." Cannot reproduce this one. I toggle various libraries from Yes to No and vv.
. Creating a new library - even if you change public to "No", it saves as public with "Yes". Yes, good catch. Editing existing libraries works here. But adding a library does not respect the public flag! Opening a new report.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- When you have a lot of branches, use SQL: update branches set public=0; And set one branch back to Yes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31785 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #5)
. Creating a new library - even if you change public to "No", it saves as public with "Yes". Yes, good catch. Editing existing libraries works here. But adding a library does not respect the public flag! Opening a new report.
Fixed on bug 31785 now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141824|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 141871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141871&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141825|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 141872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141872&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #10 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker). 1. I applied bug 31785 (so can toggle Public to No) (Alternative is to use SQL: update branches set public=0; and then set two libraries back to Yes.) 2. Add some additional information to the OPAC page for a library (for example, Centerville) at Tools > Additional tools > HTML customisations > New entry > select OpacLibraryInfo 3. Check the OPAC page for the library to make sure this is visible: OPAC Home > Libraries > [List of Libraries] > click link for Centerville: - Note that for the list of libraries, each library is linked to an individual page - On the list of libraries page, the information entered in the Libraries Administration area is displayed - Note that for the individual library page it includes the information on the listing page, as well as any info entered in step 2 4. Make all other libraries except Centerville not public: Administration > Basic parameters > Libraries: - Change public to no for all libraries except Centerville (see step 1 for the SQL way to make this change) 5. Visit the OPAC page for the list of libraries: http://127.0.0.1:8080/cgi-bin/koha/opac-library.pl . Note that there is no link to the individual Centerville page . Note that only the basic library information entered in Administration > Basic parameters > Libraries is displayed 6. Apply the patch and refresh the list of libraries page: - Note that Centerville is now linked - On the individual library page for Centerville you now have the basic information and the information from step 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141871|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141933&action=edit Bug 31775: Show single library Test plan: Check both cases: one library (public accessible) and more libraries (public accessible). In the latter case click on one of these libraries too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141872|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141934&action=edit Bug 31775: Template cleanup Removing unused parts. Test plan: See first test plan. Confirm that it still works. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Bug 31775 depends on bug 29144, which changed state. Bug 29144 Summary: Move branches.opac_info to AdditionalContents allowing multi language https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31775 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org