[Bug 18763] New: swagger/definitions.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Bug ID: 18763 Summary: swagger/definitions.t is failing Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: gmcharlt@gmail.com # Failed test 'Columns are missing for patron: lang, overdrive_auth_token, login_attempts' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64118&action=edit Bug 18763: Fix swagger/definitions.t tests Test plan: prove api/v1/swagger/definitions/patron.json must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18508 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64118|0 |1 is obsolete| | --- Comment #2 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64119&action=edit [SIGNED OFF] Bug 18763: Fix swagger/definitions.t Test plan: prove api/v1/swagger/definitions/patron.json must return green Signed-off-by: Lee Jamison <ldjamison@marywood.edu> swagger/definitions.t test returns green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 Test plan says : prove api/v1/swagger/definitions/patron.json It is : prove t/db_dependent/api/v1/swagger/definitions.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Test fails for me locally, but columns listed are not in 16.11.x - please provide a separate patch for this version if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Test Summary Report ------------------- api/v1/swagger/definitions/patron.json (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: No plan found in TAP output Files=1, Tests=0, 0 wallclock secs ( 0.01 usr + 0.01 sys = 0.02 CPU) Result: FAIL kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove api/v1/swagger/definitions/patron.json api/v1/swagger/definitions/patron.json .. syntax error at api/v1/swagger/definitions/patron.json line 2, near ""type":" Execution of api/v1/swagger/definitions/patron.json aborted due to compilation errors. api/v1/swagger/definitions/patron.json .. Dubious, test returned 255 (wstat 65280, 0xff00) No subtests run -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Won't apply to 16.11.x as is, closing! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org