https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think this is not ready, but could be used as a first step. 1. Should we support UNIMARC? 2. The retrieval of the OLID should be move to C4::Koha alongwith GetNormalizedISBN (or Koha::Biblio, with get_normalized_isbn), and test covered. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 --- Comment #4 from nigel@titley.com --- Many thanks for the work you've done already. This certainly seems to be retrieving the cover in the case where there is no ISBN and there is an OLID, which is what I wanted. Looking at the code I think you are missing a test in Search.pm around line 1747. I'm not familiar enough with Koha data structures to actually modify the code but MARC 21 says that you only check subfield 2 if the first indicator contains the value 7 and I think your code checks subfield 2 regardless of the state of the first indicator. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 --- Comment #6 from nigel@titley.com --- Of course I will. And I can't say how grateful I am that you've done most of the work. It mostly looks done. I'll tidy it up as per my previous comments and run it for a bit and give it a thorough test. I'll look at sorting out formal testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34527 --- Comment #8 from nigel@titley.com --- I already got koha-testing-docker working and in fact I applied Jonathan's patch to it in order to test it. What I think I now need to do is roll it back to virgin and then create a new branch to apply the patch to. I've read through the code and worked out the minor change that I need to make to check for the correct state of the first indicator. Once I've done that I'll apply the patch to the new branch and test again. Sorry this is such a laborious process. It's the first time I've dealt with the koha/bugzilla process. -- You are receiving this mail because: You are watching all bug changes.