[Bug 33512] New: Labels/buttons are confusing on serials-edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Bug ID: 33512 Summary: Labels/buttons are confusing on serials-edit page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org TO recreate: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. At this point you are actually editing an item, not adding an item. This is confusing and leads librarians to never edit these items because they assume they are adding an item, not editing the existing one. Also, the 'Click to add item' is small and grey. It should look more like a button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149580&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149580|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 149605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149605&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Lovely...much less confusing now. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149605|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149719&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149720&action=edit Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, I just realized that we had the "Click to..." previous to your patches, but we should not do that. I've added a small follow-up to remove them. It being a link or button already indicates that you can click it, see also accessibility guidelines like: https://www.mtu.edu/accessibility/training/web/link-text/ Hope you agree :) But: The edit/add text change doesn't work perfectly yet: To test: * Add a new subscription creating items on receive * Receive a first issue and create the item * From serial collection check both issues and edit * The unreceived issue in status "arrived also has "Edit item", but there is no item to edit yet I really like this change, can you please have another look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Hi Lucas,
I just realized that we had the "Click to..." previous to your patches, but we should not do that. I've added a small follow-up to remove them. It being a link or button already indicates that you can click it, see also accessibility guidelines like: https://www.mtu.edu/accessibility/training/web/link-text/ Hope you agree :)
But: The edit/add text change doesn't work perfectly yet:
To test: * Add a new subscription creating items on receive * Receive a first issue and create the item * From serial collection check both issues and edit * The unreceived issue in status "arrived also has "Edit item", but there is no item to edit yet
I really like this change, can you please have another look?
Good catch Katrin. I 100% agree with you. Should we set this back to NSO? Thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #7)
(In reply to Katrin Fischer from comment #6)
Hi Lucas,
I just realized that we had the "Click to..." previous to your patches, but we should not do that. I've added a small follow-up to remove them. It being a link or button already indicates that you can click it, see also accessibility guidelines like: https://www.mtu.edu/accessibility/training/web/link-text/ Hope you agree :)
But: The edit/add text change doesn't work perfectly yet:
To test: * Add a new subscription creating items on receive * Receive a first issue and create the item * From serial collection check both issues and edit * The unreceived issue in status "arrived also has "Edit item", but there is no item to edit yet
I really like this change, can you please have another look?
Good catch Katrin. I 100% agree with you. Should we set this back to NSO? Thanks for the follow-up!
I couldn't fix the second issue - so we will still need a follow up or maybe change to "Add/edit item" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150179&action=edit Bug 33512: (follow-up) Check item count before adding add/edit button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> ---
I couldn't fix the second issue - so we will still need a follow up or maybe change to "Add/edit item"
Katrin, let me know what you think of my follow-up for the 2nd issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149719|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150906&action=edit Bug 33512: Change text and add button classes on serial-edit page To test: 1. Create a subscription 2. Make sure that you choose "Create an item record" when receiving the serial and associate it with a record. 3. Fill out the numbering pattern stuff and save the subscription. 4. Receive and change the status to arrived. Doing so will make the item subfields appear for editing. 5. Add some stuff, like a barcode, and Save. 6. Now, if you have made a mistake, you may want to edit the serial/item. Check the edit box and click 'Edit serials ' 7. For your issue that has already arrived click 'Click to add item'. The item record from before appears. 8. Apply patch. 9. Try 6 & 7 again. The existing items should now read 'Click to edit item' Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149720|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150907&action=edit Bug 33512: (QA follow-up) Remove 'Click to' from buttons This is following recommendations from accessibility guidelines. It being a link or button already indicates that you need to click it. We don't need to spell it out. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150179|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150908&action=edit Bug 33512: (follow-up) Check item count before adding add/edit button Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33512 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |danyonsewell@catalyst.net.n | |z --- Comment #17 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Not backporting to 21.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org