[Bug 17514] New: Record details page uses incorrect class "results_summary "
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Bug ID: 17514 Summary: Record details page uses incorrect class "results_summary" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The record details page re-uses the class results_summary which is semantically incorrect and causes unwanted interactions with the styling of the actual results page which also uses the results_summary class. We should change the instances of the results_summary class to details_summary on this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 56923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56923&action=edit Bug 17514 - Record details page uses incorrect class "results_summary" The record details page re-uses the class results_summary which is semantically incorrect and causes unwanted interactions with the styling of the actual results page which also uses the results_summary class. We should change the instances of the results_summary class to details_summary on this page. Test Plan: 1) Apply this patch 2) Browse to the record details for a bib 3) View the html, note that no elements have the class results_summary, instead, you should see the class details_summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I agree about the semantic issue, but is the practical aspect of this that it creates problems with customizations? If we have a patch adding details_summary, staff-global.css should be modified to add style for it so that it doesn't break the existing view. As it is, tags, MARC preview, and Holds all display on the same line. This patch must also modify the XSL stylesheet since many of the "results_summary" instances come from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Also: This patch modifies the staff client template, but the same issue exists in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Owen - we are using results_summary in combination with the unique id from the body which avoids any problems. But we'd probably have to change the CSS for quite a few libraries if these classes were changed suddenly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, would you agree to make this WONTFIX? (see last comments) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
Kyle, would you agree to make this WONTFIX? (see last comments)
Interpreting 2.5 years of silence as yes :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org