[Bug 14817] New: Encoding issues in columns.def
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Bug ID: 14817 Summary: Encoding issues in columns.def Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The columns.def file is not opened using the utf-8 encoding. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11944 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 [Bug 11944] Cleanup Koha UTF-8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42524&action=edit Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14808 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- The patch works as expected for me, but there is another place to fix: https://github.com/Koha-Community/Koha/blob/master/C4/Reports/Guided.pm#L875 And there is used this routine from Reports::Guided https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L37 https://github.com/Koha-Community/Koha/blob/master/tools/inventory.pl#L374 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42571&action=edit Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Thanks for the catch Josef, I haven't checked this area I thought it called the same subroutine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42524|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 42582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42582&action=edit Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42571|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 42583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42583&action=edit Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42582|0 |1 is obsolete| | Attachment #42583|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42713&action=edit [PASSED QA] Bug 14817: Fix encoding issues in columns.def Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the tools/import_patrons.pl page 3/ The field names in the "default values" block should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42714&action=edit [PASSED QA] Bug 14817: (follow-up) Fix encoding issues in columns.def Follow-up for reports. Test plan: 1/ Use a translated template (fr-FR or ar-Arab) 2/ Go on the report guided page, step 3 3/ The field names should be correctly encoded. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14817 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org