[Bug 20567] New: "Holds per record (count)" limit is not enforced after item is captured for hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Bug ID: 20567 Summary: "Holds per record (count)" limit is not enforced after item is captured for hold Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: margaret@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 74042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74042&action=edit Multiple holds on one item record in staff client "Holds per record (count)" limit is not enforced after an item on the record is captured for hold and moves from Pending to Waiting Pickup status. At this point it is possible to place another hold on that record in violation of the "Holds per record (count)" setting. I was able to replicate this behavior with the following steps: 1. Set "Holds per record (count)" to 1 for your patron category/item type rule 2. Create a record and add at least two items, making sure the MARC and Item Koha Item Type is filled in 3. Place a hold on the record for a patron 4. Check in one of the items and confirm/transfer/capture the hold for the patron 5. Place a second hold on the same record for the same patron In either Staff or Opac the second hold on this bib is allowed after the first hold moves to Waiting for Pickup status. I think that this problem is very closely related to bugzilla 17978 and or 15404, but I did not see a specific mention of the "Holds per record (count)" limit upon perusal of those bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17978 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15404 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I would not classify this as a minor bug. If limits are not being enforced in all conditions, this is a problem. At the very least, there needs to be a preference to change this oversight, if for some reason there is justification to keep this unusual behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14695 Status|NEW |In Discussion CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that it is the expected behavior. C4/Circulation.pm, in CanItemBeReserved: 394 found => undef, # Found holds don't count against a patron's holds limit Should not it be? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se --- Comment #3 from Hans Pålsson <hans.palsson@hkr.se> --- (In reply to Jonathan Druart from comment #2)
It seems that it is the expected behavior.
C4/Circulation.pm, in CanItemBeReserved: 394 found => undef, # Found holds don't count against a patron's holds limit
Should not it be?
No, a patron should only be allowed 1 hold per biblio, also after that hold is filled. It translates to patrons should not be able to place holds on biblios for which they have checked out items or already placed a hold. The current behaviour becomes a loophole. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #4 from Hans Pålsson <hans.palsson@hkr.se> --- (In reply to Jonathan Druart from comment #2)
C4/Circulation.pm, in CanItemBeReserved: 394 found => undef, # Found holds don't count against a patron's holds limit
I think it is C4/Reserves.pm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I understand why you would NOT want to count the waiting holds, but I wonder if we are missing a use case here if we change that too quickly. Maybe we coudl compare to how other hold counts, like the daily limit, work here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97336&action=edit Bug 20567: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97337&action=edit Bug 20567: Count found holds for holds limit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same as Katrin here, I submitted a patch that should modify the behavior as you expect, but I am not sure it's correct (side effects). That would be good to get Kyle's opinion on this, as he wrote that bit of code (the comment on the line I remove especially). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #9 from Hans Pålsson <hans.palsson@hkr.se> --- The problem is on item level more than on biblio level. If a library only allows 1 item to be reserved per biblio, then the current code creates the loophole. That is the problem we have and the same as reported in this bug. If the amount of holds placed should count towards a patrons total amount of holds placed on different biblios, then the current code makes sense. I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #8)
Same as Katrin here, I submitted a patch that should modify the behavior as you expect, but I am not sure it's correct (side effects). That would be good to get Kyle's opinion on this, as he wrote that bit of code (the comment on the line I remove especially).
I'm researching the issue to see if the original development funder(s) had this behavior as a requirement or not. In any case it would be trivial to syspref this to satisfy both those who want the existing behavior and those who do not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Hans Pålsson <hans.palsson@hkr.se> --- Signing of because patch solves initial problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com --- Comment #12 from Benjamin Daeuber <bdaeuber@cityoffargo.com> --- We are the sponsoring library Kyle refers to. While we hadn't noticed this, I guess I would agree with the opinion here, a hold in waiting status is still a hold. That said, if someone wants a syspref, that's fine, but I guess everyone here seems to agree waiting hold and pending holds ought to be counted together. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Benjamin Daeuber from comment #12)
We are the sponsoring library Kyle refers to. While we hadn't noticed this, I guess I would agree with the opinion here, a hold in waiting status is still a hold.
That said, if someone wants a syspref, that's fine, but I guess everyone here seems to agree waiting hold and pending holds ought to be counted together.
Thx Benjamin for commenting! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Based on Ben's response, my opinion is that this change in behavior does not need to be syspref'ed at this time! (In reply to Katrin Fischer from comment #13)
(In reply to Benjamin Daeuber from comment #12)
We are the sponsoring library Kyle refers to. While we hadn't noticed this, I guess I would agree with the opinion here, a hold in waiting status is still a hold.
That said, if someone wants a syspref, that's fine, but I guess everyone here seems to agree waiting hold and pending holds ought to be counted together.
Thx Benjamin for commenting!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97336|0 |1 is obsolete| | Attachment #97337|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97386&action=edit Bug 20567: Add tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97387&action=edit Bug 20567: Count found holds for holds limit Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97386|0 |1 is obsolete| | Attachment #97387|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97388&action=edit Bug 20567: Add tests Signed-off-by: Hans Palsson <hans.palsson@hkr.se> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97389&action=edit Bug 20567: Count found holds for holds limit Signed-off-by: Hans Palsson <hans.palsson@hkr.se> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 --- Comment #20 from Hans Pålsson <hans.palsson@hkr.se> --- (In reply to Martin Renvoize from comment #19)
Nice work everyone!
Pushed to master for 20.05
:-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #23 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Enhancement/patch will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22005 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25566 [Bug 25566] Change in DecreaseLoanHighHolds behaviour -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org