https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129705&action=edit Bug 29924: Database updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129707&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home->Administration->Patron categories->Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration field is set SELECT password_expiration FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you cna now sign in and password_expiration field is set 10 days in the future 15 - Expire the patron's password again 16 - Chaneg the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29926 [Bug 29926] Add ability for superlibrarians to edit password expiration dates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129763&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129765&action=edit Bug 29924: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Some thoughts: - Why is the "Your password has expired" page in the OPAC empty, whereas the "Incorrect password" page shows the search bar and the other search links? - Should we show the password expiration on the patron detail page? Under the password line? - Should we show a (non-blocking) warning on the checkout page when a patron's password has expired like we do when their account has expired? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #10)

Some thoughts:

- Why is the "Your password has expired" page in the OPAC empty, whereas the "Incorrect password" page shows the search bar and the other search links?

Fixed - we generate a lot of necessary content for the template in the routine, so I delay the output until the end

- Should we show the password expiration on the patron detail page? Under the password line?

- Should we show a (non-blocking) warning on the checkout page when a patron's password has expired like we do when their account has expired?

I am not sure on these, on other systems where my password expires I don't see these. It is debatable whether general staff need to know this, I think these options would need to be configurable, open a follow-up bug? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129762|0 |1 is obsolete| | Attachment #129763|0 |1 is obsolete| | Attachment #129764|0 |1 is obsolete| | Attachment #129765|0 |1 is obsolete| | Attachment #129766|0 |1 is obsolete| | Attachment #129823|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129953&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129955&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129957&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130117&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130119&action=edit Bug 29924: Unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130495&action=edit Bug 29924: (follow-up) Add password_expiration_date to API -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130116|0 |1 is obsolete| | Attachment #130117|0 |1 is obsolete| | Attachment #130118|0 |1 is obsolete| | Attachment #130119|0 |1 is obsolete| | Attachment #130120|0 |1 is obsolete| | Attachment #130495|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130500&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130502&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 130504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130504&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130558&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130560&action=edit Bug 29924: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 130562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130562&action=edit Bug 29924: (follow-up) Add password_expiration_date to API Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130557|0 |1 is obsolete| | --- Comment #37 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130677&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130559|0 |1 is obsolete| | --- Comment #39 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130679&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130561|0 |1 is obsolete| | --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130681&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130563|0 |1 is obsolete| | --- Comment #43 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 130683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130683&action=edit Bug 29924: (follow-up) Adjust test count Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130677|0 |1 is obsolete| | Attachment #130678|0 |1 is obsolete| | Attachment #130679|0 |1 is obsolete| | Attachment #130680|0 |1 is obsolete| | Attachment #130681|0 |1 is obsolete| | Attachment #130682|0 |1 is obsolete| | Attachment #130683|0 |1 is obsolete| | Attachment #131128|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132059&action=edit Bug 29924: Database updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132061&action=edit Bug 29924: Unit tests Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132063&action=edit Bug 29924: (follow-up) Add password_expiration_date to API Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132065&action=edit Bug 29924: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132066|0 |1 is obsolete| | --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132084&action=edit Bug 29924: Update ILSDI to be aware of expired passwords To test: 1 - Enable ILSDI 2 - Set a patron password with expired password 3 - http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=usernam&password=password 4 - Confirm 'PasswordExpired' returned -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132060|0 |1 is obsolete| | --- Comment #55 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 132086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132086&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132062|0 |1 is obsolete| | --- Comment #57 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 132088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132088&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132064|0 |1 is obsolete| | --- Comment #59 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 132090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132090&action=edit Bug 29924: (follow-up) Add default value undef for TestBuilder Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132084|0 |1 is obsolete| | --- Comment #61 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 132092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132092&action=edit Bug 29924: Update ILSDI to be aware of expired passwords To test: 1 - Enable ILSDI 2 - Set a patron password with expired password 3 - http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=AuthenticatePatron&username=usernam&password=password 4 - Confirm 'PasswordExpired' returned Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #62 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nick, do you *need* the password expiration on the API response? Can we remove it and have a separate route for dealing with that? It will become tricky with security, and also in light of the discussion on bug 28786 and friends, I think we should expose it in some other way if required. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30592 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30592 [Bug 30592] Move borrowers.secret to a new generic credentials table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|Signed Off |Patch doesn't apply --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133742&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #68 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133744&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133746&action=edit Bug 29924: (follow-up) Add default value undef for TestBuilder Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #72 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 133748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133748&action=edit Bug 29924: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133742|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133802&action=edit Bug 29924: Add password expiration feature This patch adds the ability to define password_expiry_days for a patron category. When defined a patron's password will expire after X days and they will be required to reset their password. If OPAC resets are enabled for the catgeory they may do so on their own, otherwise they will need to contact the library To test: 1 - Apply patch, updatedatabase 2 - Set 'Password expiration' for a patron category Home-> Administration-> Patron categories-> Edit 3 - Create a new patron in this category with a userid/password set, and an email 4 - Confirm their password_expiration_date field is set SELECT password_expiration_date FROM borrowers WHERE borrowernumber=51; 5 - Create a new patron, do not set a password 6 - Confirm their password_expiration_date field is NULL 7 - Update the patron with an expiration to be expired UPDATE borrowers SET password_expiration_date='2022-01-01' WHERE borrowernumber=51; 8 - Give the borrower catalogue permission 9 - Attempt to log in to Straff interface 10 - Confirm you are signed out and notified that password must be reset 11 - Attempt to sign in to OPAC 12 - Confirm you are signed out and notified password must be reset 13 - Enable password reset for the patron's category and perform a password reset Note: you will have to find the link in the message_queue unless you have emails setup on your test environment SELECT * FROM message_queue WHERE borrowernumber=51; 14 - Confirm that you can now sign in and password_expiration_date field is set 10 days in the future 15 - Expire the patron's password again 16 - Change the patron's password via the staff interface 17 - Confirm they can sign in and the expiration is updated Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133804&action=edit Bug 29924: (follow-up) Add bug number to atomicupdate; Style OPAC message - The atomicupdate didn't have "bug_number" defined. - The "Your password has expired" message is now styled with the same class as other OPAC login messages. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133806&action=edit Bug 29924: (follow-up) Add default value undef for TestBuilder Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133808&action=edit Bug 29924: DO NOT PUSH - Schema updates Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #82 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 133810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133810&action=edit Bug 29924: Add tests for API Basic auth behavior Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 --- Comment #85 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 134758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134758&action=edit Bug 29924: (follow-up) Fix t/db_dependent/Koha/Patron.t number of tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/585 -- You are receiving this mail because: You are watching all bug changes.