[Bug 22501] New: OPAC course reserves notes should allow html links
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Bug ID: 22501 Summary: OPAC course reserves notes should allow html links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Some libraries have been using the public notes field to point to electronic resources, this functionality has been removed by HTML filtering the content. We should allow the use of a $raw filter on these fields as they can only be entered by staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 87127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87127&action=edit Attachment to Bug 22501 - OPAC course reserves notes should allow html links Bug 22501: OPAC course reserves notes should allow html links Test Plan: 1. Add a new course a put '<a href=""></a>' in the public not field. 2. Go to the course in the OPAC. 3. Notice that the HTML displays literally 4. Apply patch and reload page 5. The <a> tag should render as HTML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87127|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87329&action=edit Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87329|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87380&action=edit Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Passed QA |Failed QA Patch complexity|Trivial patch |--- --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This fixes the note on course level, from the description I was wondering if it should be the public note on course reserve item level? It also only fixes the OPAC side, but still displays escaped in staff. I think both should match to give the correct preview of the entered HTML code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87658&action=edit Bug 22501: (QA Follow-up) use $raw for the note in the intranet -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Yep I think we should have this in the intranet too, I've added a follow up for that. It might be scope-creep to change the item level notes, but that could definitely go on another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, please use the QA tools on your patches - it will show you if there are any complaints. In this case, there is a small 'typo' in the first commit message. I will fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87380|0 |1 is obsolete| | Attachment #87658|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87735&action=edit Bug 22501: OPAC course reserves notes should allow html links Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87736&action=edit Bug 22501: (QA follow-up) use $raw for the note in the intranet Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87737&action=edit Bug 22501: Add raw filter to course reserves summary page Fixes another place where the public note is shown: - Course reserves module start/summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88333&action=edit Bug 22501: (follow-up) Use raw filter for course note on details page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, what more is needed here? (additional_work_needed) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #14)
Hi Nick, what more is needed here? (additional_work_needed)
I added an additional patch, the notes in course details were still filtered, it should be pushed to all versions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #15)
(In reply to Katrin Fischer from comment #14)
Hi Nick, what more is needed here? (additional_work_needed)
I added an additional patch, the notes in course details were still filtered, it should be pushed to all versions
(In reply to Nick Clemens from comment #13)
Created attachment 88333 [details] [review] Bug 22501: (follow-up) Use raw filter for course note on details page
Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40079 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org