[Bug 16893] New: Missing closing tag disrupts patron detail page style
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Bug ID: 16893 Summary: Missing closing tag disrupts patron detail page style Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/members/moremember.pl?borrowernumber=X OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 12509 There is a missing closing </i> in the moremember.tt template when the patron has a restriction message. The whole page is in italics. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12509 [Bug 12509] Untranslatable "Restriction added by overdues process" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53265&action=edit Bug 16893 - Missing closing tag disrupts patron detail page style A missing closing </i> causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53265|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53270&action=edit [SIGNED-OFF]Bug 16893: Missing closing tag disrupts patron detail page style A missing closing </i> causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rest of the page displayed normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53270|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53285&action=edit [PASSED QA] Bug 16893: Missing closing tag disrupts patron detail page style A missing closing </i> causes the the patron detail page to be in all italics if the patron has a restriction message. This patch corrects it. To test, apply the patch and locate a patron who has a restriction message. The restriction message should be in italics but the rest of the page should display normally. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Rest of the page displayed normally Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53286&action=edit Bug 16893 - Missing closing tag disrupts patron checkouts page style Same fix as for the details page: checkouts page is very italic when there is a restriction with a comment on the patron account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen, Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16893 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org