[Bug 15093] New: item type groups not saving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Bug ID: 15093 Summary: item type groups not saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 10937 See here: http://screencast.com/t/qKx78oxQ When I add an item type to a group it doesn't seem save. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Option to hide and group itemtypes from advanced search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44256&action=edit Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44256|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44257&action=edit Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44257|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44272&action=edit [PASSED QA] Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org