[Bug 14788] New: Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Bug ID: 14788 Summary: Move opac-topissues.pl code into C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 42406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42406&action=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14749 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14749 [Bug 14749] Add API route to get top issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11139 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 [Bug 11139] opac-topissues does not work with CCODE -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Hi Julian, With the patch, the checkouts on the result table do no longer sort numerically but alpabetically, something like: 1 -14 - 2- 26- 89 instead of 1 -2 -14 -26- 89 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Marc, I have the same behaviour on master, I don't think the patch is responsible for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created a new bug: Bug 14940 Switching back to Needs signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42406|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 43051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43051&action=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, please provide tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 43115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43115&action=edit Bug 14788: Add unit tests for GetTopIssues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43051|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 43184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43184&action=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43115|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 43185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43185&action=edit Bug 14788: Add unit tests for GetTopIssues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master. Minor conflict resolved, switching back to Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43730&action=edit [PASSED QA] Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43731&action=edit [PASSED QA] Bug 14788: Add unit tests for GetTopIssues Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is an improvement over the current code, but needs to be pushed together with bug 11139 that will actually make it work nicely :) If you add multiple values in AdvancedSearchTypes with only this patch, it doesn't work quite right yet - but tested with 11139 things look alright. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Good job Julian! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ]% prove t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/GetTopIssues.t .. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Circulation/GetTopIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/Circulation/GetTopIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.02 csys = 1.44 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok... The AI on my biblio and biblioitems tables differ. I don't really know why... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org