http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8207&action=edit Bug 7719 - Change state of controls based on whether boxes are checked Some OPAC interface controls cannot function unless a checkbox is checked. Examples: - Placing a hold on multiple items in the cart window or on a list view page - Adding tags to multiple items in the cart window or on a list view page - Removing one or more items from the cart window - Removing one or more items from a list on the list view page - Adding one or more items to a list from the cart window This patch moves these controls into a separate div in which links are enabled or disabled based on whether checkboxes are checked. It does so on two pages: The lists view page (when viewing the contents of a list) and in the cart window. Links which are in their disabled state should not perform any action. After checking one or more checkboxes the links should become active and behave normally. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8207|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8208&action=edit Bug 7719 - Change state of controls based on whether boxes are checked Some OPAC interface controls cannot function unless a checkbox is checked. Examples: - Placing a hold on multiple items in the cart window or on a list view page - Adding tags to multiple items in the cart window or on a list view page - Removing one or more items from the cart window - Removing one or more items from a list on the list view page - Adding one or more items to a list from the cart window This patch moves these controls into a separate div in which links are enabled or disabled based on whether checkboxes are checked. It does so on two pages: The lists view page (when viewing the contents of a list) and in the cart window. Links which are in their disabled state should not perform any action. After checking one or more checkboxes the links should become active and behave normally. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works in chrome and firefox (latest). Passes tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6264 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---

I have one qualm about this- will it degrade gracefully for browsers without javascript enabled?

Because the controls perform functions which are only available if JavaScript is enabled this patch causes no additional loss of functionality to users with JS turned off. As with current master, the controls do not appear if JS is turned off. I do see a problem where one of my labels still shows up with JS turned off. I'll submit a follow-up. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- patch pushed, a nice enhancement that 3.6 users will also enjoy ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.