[Bug 16851] New: Move HasOverdues to Koha::Patron->has_overdues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Bug ID: 16851 Summary: Move HasOverdues to Koha::Patron->has_overdues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Blocks: 16850 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16850 [Bug 16850] Move IsMemberBlocked to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16849 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16849 [Bug 16849] Move IsDebarred to Koha::Patron->is_debarred -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53094&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm getting an error when opening the circulation or patron detail pages for a patron: Template process failed: plugin error - Global symbol "$borrower" requires explicit package name at Koha/Template/Plugin/Borrowers.pm line 57. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53094|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53325&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #2)
I'm getting an error when opening the circulation or patron detail pages for a patron:
Template process failed: plugin error - Global symbol "$borrower" requires explicit package name at Koha/Template/Plugin/Borrowers.pm line 57. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Plugins.pm line 206.
Sorry about that Owen! Silly c/p error... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Applying: Bug 16851: Move HasOverdues to Koha::Patron->has_overdues fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 16851: Move HasOverdues to Koha::Patron->has_overdues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53325|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53511&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Conflicts with bug 16853 fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53511|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53996&action=edit [SIGNED-OFF] Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53996|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55190&action=edit Bug 16851: Move HasOverdues to Koha::Patron->has_overdues This patch just move C4::Members::HasOverdues to Koha::Patron->has_overdues and updated callers Test plan: No change in behavior is expected. 1/ If a patron is debarred and does not have overdues and AutoRemoveOverduesRestrictions is on, the debarment will be removed on checkin 2/ Add overdues and make sure the patron cannot renew Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55425&action=edit Bug 16851 [QA Followup] - Fix Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55425|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 55426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55426&action=edit Bug 16851 [QA Followup] - Fix Unit Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org