[Bug 11546] New: facets labels are not css selectable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Bug ID: 11546 Summary: facets labels are not css selectable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: francescalamoore@gmail.com QA Contact: testopia@bugs.koha-community.org add span tags to h5 headings to make them easily selectable in css -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #1 from Francesca <francescalamoore@gmail.com> --- Created attachment 24256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24256&action=edit propose patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Francesca <francescalamoore@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 24262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24262&action=edit bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24256|0 |1 is obsolete| | Attachment #24262|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 24269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24269&action=edit bug 11546 facets labels are not css selectable To test: 1. search in OPAC directory 2. inspect the facets, note that they now have spans Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. I'm not sure that this change is necessary, since the parent li elements have IDs that can be hooked onto for CSS, but it doesn't change existing behaviour and more control is always nice, so that's all right. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart@biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- I create a patch for that in bug 11312. *** This bug has been marked as a duplicate of bug 11312 *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Francesca, Perhaps you could test Jonathan's patch on bug 11312, and sign off on that. Which I'm sure Jonathan would appreciate. And we will find a new bug to get your first patch into Koha. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11546 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- It seems I was a little bit boorish, I am sorry Francesca. I did not see it was your first patch! I will add it on bug 11312. Thank you for your signoff! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org