[Bug 27446] New: Markup errors in suggestion/suggestion.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Bug ID: 27446 Summary: Markup errors in suggestion/suggestion.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org While working on a separate issue I notices there are several markup errors in suggestion/suggestion.tt. 1. <h2> tag closes with an </h3> 2. Some button elements are using the self-closing syntax when they should not 3. <div id="limits> does not close 4. There are some stray </div>'s 5. Indentation/white could be better -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115774&action=edit Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115774|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 115792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115792&action=edit Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I tested on Firefox and Google Chrome (latest versions) on Ubuntu 18.04. Everything seemed to work fine, with the caveat that I'm not that familiar with suggestions. I did check the page with WebAIM's WAVE toolbar, however I think the potential issues it identifies are a separate project (for the whole of Koha). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115792|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115840&action=edit Bug 27446: Markup errors in suggestion/suggestion.tt This patch makes various corrections to the suggestions template in the staff interface: - Correct indentation - Fix unclosed tags - Fix non-unique IDs - Add comments to highlight markup structure To test, apply the patch and test the suggestions interface in the staff client: - Viewing the list of suggestions - Viewing the details of a single suggestion - Filtering suggestions - Organizing suggestions Test that labels on form controls work correctly, including under each tab. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115841&action=edit Bug 27446: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes several release notes| |markup errors in the | |suggestions template in the | |staff interface, including: | |- Indentation | |- Unclosed | |tags | |- Non-unique IDs | |- | |Adding comments to | |highlight markup structure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27446 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org