[Bug 30168] New: Use checkout object in GetSoonestRenewDate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Bug ID: 30168 Summary: Use checkout object in GetSoonestRenewDate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Currently we fetch the checkout, patron, and item when calculating the soonest renewal date Lets instead pass the checkout object and fetch from there, allowing to prefetch in the calling routine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Depends on| |30167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30167 [Bug 30167] Return soonest renewal date when CanBookBeRenewed returns %too_soon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131048&action=edit Bug 30168: Use checkout object in GetSoonestRenewDate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131049&action=edit Bug 30168: Embed patron and item in issue for passing to GetSoonestRenewDate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #2)
Created attachment 131049 [details] [review] Bug 30168: Embed patron and item in issue for passing to GetSoonestRenewDate
Obsoleting, see bug 30169 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131049|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131048|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134603&action=edit Bug 30168: Use checkout object in GetSoonestRenewDate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134603|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 140969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140969&action=edit Bug 30168: Use checkout object in GetSoonestRenewDate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- I've signed off on the basis that the tests pass before and after the patch is applied: prove t/db_dependent/Circulation.t Let me know if there is anything else required to test this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #7 from David Nind <david@davidnind.com> --- I also ran similar tests to bug 30167, for what it is worth. - Tested on 09/25/2022 (American date format) with . 'no renewal before' set to 3 . 'loan period' set to 5 - Checked out on date is 09/25/2022 05:10 - For the patron from the checkouts: No renewal before 04/27/2022 - When trying to renew from Circulation > Renew, the message is "Intermediate Perl / ( 39999000005134 ) cannot be renewed before 09/27/2022." - When trying to renew by checking out to the same patron again, the message is: "No more renewals possible" - Date is calculated correctly including the current day (3 days - 25th, 26th + 27th) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #7)
I also ran similar tests to bug 30167, for what it is worth.
- Tested on 09/25/2022 (American date format) with . 'no renewal before' set to 3 . 'loan period' set to 5 - Checked out on date is 09/25/2022 05:10 - For the patron from the checkouts: No renewal before 04/27/2022 - When trying to renew from Circulation > Renew, the message is "Intermediate Perl / ( 39999000005134 ) cannot be renewed before 09/27/2022." - When trying to renew by checking out to the same patron again, the message is: "No more renewals possible" - Date is calculated correctly including the current day (3 days - 25th, 26th + 27th)
Thanks David, your notes are always very helpful! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140969|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141554&action=edit Bug 30168: Use checkout object in GetSoonestRenewDate Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141555&action=edit Bug 30168: (QA follow-up) Fix POD The POD had $issue in the example, but $checkout in explanation. Also standardized a bit of other terminology. (borrower, issue) = (patron, checkout) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30168 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org