[Bug 8463] New: t_00_testcritic_t.Test::Perl::Critic for "Koha/SearchEngine/Solr/Search.pm"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Priority: P5 - low Change sponsored?: --- Bug ID: 8463 Assignee: gmcharlt@gmail.com Summary: t_00_testcritic_t.Test::Perl::Critic for "Koha/SearchEngine/Solr/Search.pm" Severity: major Classification: Unclassified OS: All Reporter: mtj@kohaaloha.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha Koha/SearchEngine/Solr/Search.pm fails perlcritic test -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|t_00_testcritic_t.Test::Per |Koha/SearchEngine/Solr/Sear |l::Critic for |ch.pm fails perlcritic test |"Koha/SearchEngine/Solr/Sea | |rch.pm" | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 --- Comment #1 from Mason James <mtj@kohaaloha.com> --- Created attachment 10915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10915&action=edit Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test modified: Koha/SearchEngine/Solr/Search.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #1)
Created attachment 10915 [details] Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
modified: Koha/SearchEngine/Solr/Search.pm
- before patch... $ perlcritic Koha/SearchEngine/Solr/Search.pm Variable declared in conditional statement at line 41, column 5. Declare variables outside of the condition. (Severity: 5) - after patch... $ perlcritic Koha/SearchEngine/Solr/Search.pm Koha/SearchEngine/Solr/Search.pm source OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10915|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 10933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10933&action=edit Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test modified: Koha/SearchEngine/Solr/Search.pm Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch just for perlcritic. Fixes perlcritic stuff, so it's OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 Assignee|gmcharlt@gmail.com |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8463 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris@bigballofwax.co.nz Resolution|--- |FIXED --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org