[Bug 24782] New: Calendar edit only applies to first day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Bug ID: 24782 Summary: Calendar edit only applies to first day Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: emmi.takkinen@outlook.com QA Contact: testopia@bugs.koha-community.org When editing holidays edit only applies to first day (from date). To test: 1. Add holidays on range e.g from 04/03 to 06/03 2. Try edit these holidays so that from date is 04/03 and to date is set to 06/03 3. Save => Only 04/03 is changed There should be option to edit holidays on range. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Holidays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Alexander Borkowski <alexander.borkowski@kau.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski@kau.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201475&action=edit Bug 24782: Add method get_holidaytype In order to edit holidays correctly on a range we need to check their type. Currently only selected (from date) holidays type is checked. This patch adds new method get_holidaytype. To test prove t/db_dependent/Holidays.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201476&action=edit Bug 24782: Edit holidays on a range This patch adds option to edit holidays on a range. Edit will only affect holidays of same type, e.g. if holiday edit was started from is unique all unique holidays on range get same title and description. To test: 1. Add holidays on a range. 2. Attempt to edit these holidays by choosing a date with "To date" and "Edit this holiday". 3. Save changes. => Note that only the first holiday was changed. 4. Apply this patch. 5. Add unique holidays on a range. 6. Select one of the just added holidays. => Note that there is now an option called "Edit holidays on a range". 6. Set date range with "To date" option and select option "Edit holidays on a range". 7. Save changes. => All unique holidays on a range now have same title and description. 8. Now add repeatable holidays and attempt to edit them. => All repeatable holidays on range are changed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201476|0 |1 is obsolete| | --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 202223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202223&action=edit Bug 24782: Edit holidays on a range This patch adds option to edit holidays on a range. Edit will only affect holidays of same type, e.g. if holiday edit was started from is unique all unique holidays on range get same title and description. To test: 1. Add holidays on a range. 2. Attempt to edit these holidays by choosing a date with "To date" and "Edit this holiday". 3. Save changes. => Note that only the first holiday was changed. 4. Apply this patch. 5. Add unique holidays on a range. 6. Select one of the just added holidays. => Note that there is now an option called "Edit holidays on a range". 6. Set date range with "To date" option and select option "Edit holidays on a range". 7. Save changes. => All unique holidays on a range now have same title and description. 8. Now add repeatable holidays and attempt to edit them. => All repeatable holidays on range are changed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Fixed modifying Sundays. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxeinergl@gcc.edu Status|Needs Signoff |Failed QA --- Comment #5 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- This didn't working correctly for me and changes made with "edit holidays on a range" were applied to more than my specified range. Specifically, Koha did not heed the specified date range and instead applied edits to all holiday ranges I had created/edited for a particular library in the current session. If I close the sandbox and go back in to edit a range, it works fine. But as soon as I edit a second range the change spreads to every range I have touched in this session. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 --- Comment #6 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Gretchen Maxeiner from comment #5)
This didn't working correctly for me and changes made with "edit holidays on a range" were applied to more than my specified range. Specifically, Koha did not heed the specified date range and instead applied edits to all holiday ranges I had created/edited for a particular library in the current session. If I close the sandbox and go back in to edit a range, it works fine. But as soon as I edit a second range the change spreads to every range I have touched in this session.
We noticed this too while testing, it happens because one of the arrays is not reseted. I filed a new bug 43150 about this but forgot to mention it in this bug. I'll mark this bug depended on bug 43150. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43150 Status|Failed QA |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43150 [Bug 43150] Deleting holidays on range may sometimes delete too many holidays -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Gretchen Maxeiner <maxeinergl@gcc.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Gretchen Maxeiner <maxeinergl@gcc.edu> --- I got the following error in sandbox: Patch application failed for attachment 201475 - Bug 24782: Add method get_holidaytype. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Gretchen Maxeiner from comment #7)
I got the following error in sandbox: Patch application failed for attachment 201475 [details] [review] - Bug 24782: Add method get_holidaytype.
Hmm, t/db_dependent/Holidays.t has been deleted. Weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmi Takkinen from comment #8)
(In reply to Gretchen Maxeiner from comment #7)
I got the following error in sandbox: Patch application failed for attachment 201475 [details] [review] [review] - Bug 24782: Add method get_holidaytype.
Hmm, t/db_dependent/Holidays.t has been deleted. Weird.
Ah, it has been deleted in bug 42310. Now I wonder if this bug is now obsolete. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org