[Bug 7646] New: Printing w/o the SQL Code showing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Priority: P5 - low Change sponsored?: --- Bug ID: 7646 Assignee: gmcharlt@gmail.com Summary: Printing w/o the SQL Code showing QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: ssammons@npelem.com Hardware: All Status: NEW Version: rel_3_6 Component: Reports Product: Koha I have made modifications to the template file. It added a text link to remove the SQL statement from the print view. Thus saving the need to use CSV/TSV exports. The print text will not show on the print out as is. I added a little .noprint class to the template file. Then I added my text with a print dialog and class change JS. Please see: http://pastebin.com/LWR3BqiW for the changes specifically lines 22-26 & line 501 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #1 from Shane Sammons <ssammons@npelem.com> --- Created attachment 8025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8025&action=edit Modified the template to have a JS link to change the print media class and launch a print dialog. You can disregard the pastebin post, this patch replaces it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Shane Sammons <ssammons@npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jcamins@cpbibliography.com --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- When I apply this patch and attempt to test it, the guided reports page (/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved) has no content in the <body> tag. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #3 from Shane Sammons <ssammons@npelem.com> --- i see my mistake i will correct and re-submit. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Shane Sammons <ssammons@npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion Assignee|gmcharlt@gmail.com |ssammons@npelem.com --- Comment #4 from Shane Sammons <ssammons@npelem.com> --- Created attachment 8106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8106&action=edit Added missing </style> First time rebasing, so I am hoping this merged(squashed) correctly. Setting to In Discussion until I cna see the "diff" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Shane Sammons <ssammons@npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8025|0 |1 is obsolete| | Attachment #8106|0 |1 is obsolete| | --- Comment #5 from Shane Sammons <ssammons@npelem.com> --- Created attachment 8108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8108&action=edit should be correct this time...I hope... Failed on the previous git squash, hoping I did it right now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Shane Sammons <ssammons@npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8108|0 |1 is obsolete| | --- Comment #6 from Shane Sammons <ssammons@npelem.com> --- Created attachment 8109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8109&action=edit complete <style></style> tag this time.. I think I needed to re-make the patch file after the rebase...crosses fingers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Shane Sammons <ssammons@npelem.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #7 from Shane Sammons <ssammons@npelem.com> --- I tested it on the sandbox http://pro.test9.biblibre.com/ the link appeared on the top an SQL generated report, it launched my print box, and when I previewed the print out it did not have the SQL visable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #8 from Ian Walls <koha.sekjal@gmail.com> --- Dropping back to Needs Signoff, since signoff by someone other than the author is required. This looks to be a pretty easy one to test, but I'm about to switch trains, so I'll leave it up to another community member. Should pass QA quickly once signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8109|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 8273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8273&action=edit Bug 7646: Add "do not print SQL" link to reports I have made modifications to the template file. It added a text link to remove the SQL statement from the print view. Thus saving the need to use CSV/TSV exports. The print text will not show on the print out as is. I added a little .noprint class to the template file. Then I added my text with a print dialog and class change JS. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Ian Walls <koha.sekjal@gmail.com> --- Easy to read template only change. Marking Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: All pages include a <link rel="stylesheet" type="text/css" media="print" href="/intranet-tmpl/prog/en/css/print.css" /> for printing stylesheet that already has a .noprint class: div#breadcrumbs, div#toplevelnav, div#login, div#header_search, div#toolbar, div#changelanguage, div#menu, div.yui-b, .noprint, form#sortbyform, #cartDetails, fieldset.action, .list-actions, .print { display: none; } So this code: +<style type="text/css" media="print"> +/* ### FIX ME, PUT ME IN MAIN CSS IF USED OFTEN! */ +.noprint { +display: none; +} +</style> in your patch is useless please resubmit with this duplicate class fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8273|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 37779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37779&action=edit Bug 7646: Add "do not print SQL" link to reports I redid the patch without the superfluos CSS part for class noprint. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. The original patch was QAed in 2012, I think it is better to have put it back to "Needs Sign-off" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |aleishaamohia@hotmail.com --- Comment #13 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Patch applied cleanly but can't seem to see the print link? Setting as Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jcamins@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #14 from Marc Véron <veron@veron.ch> --- Created attachment 37790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37790&action=edit Screenshot showing position of link after applying patch I re-tested, the link appears as intended by the original patch. See screenshot. Setting back to "Needs signoff". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37926&action=edit Bug 7646 - Printing w/o the SQL Code showing This patch provides the same function but adds a 'Print results' button rather than the link. Looks a little cleaner to my eye and there doesn't seem to be an option to print with SQL. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #16 from Nick Clemens <nick@quecheelibrary.org> --- I tested, but the link looked very odd to me, added a patch to put a 'print results' button with the other action buttons. I did not obsolete the old patch so anyone can test both and see which they prefer -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #17 from Marc Véron <veron@veron.ch> --- Created attachment 37945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37945&action=edit [Signed-off] Bug 7646 - Printing w/o the SQL Code showing This patch provides the same function but adds a 'Print results' button rather than the link. Looks a little cleaner to my eye and there doesn't seem to be an option to print with SQL. To test: Go to Home > Reports > Guided reports wizard > Saved reports Select a report and run it You will find a new link "Print w/o SQL" above the title Hit this link. The report (this page) will print without the SQL statement. Works as expected. Print function is displayed as Button. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37926|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38043&action=edit Bug 7646 [QA Followup] - Tweak button to match other Koha print buttons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- A few issues: 1) Javascript embedded in html. Javascript should be moved outside the html, include the template, and include, or a js file, whichever is best suited. 2) The noprint class is added when clicking the print button, but not removed afterward 3) Only the visible results are printed, but to me the print button implies that it will print all results. If you don't want to go this far, add a tooltip to the print button so it shows "Print visible results" when you hover over it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #20 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 41093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41093&action=edit screenshot-applied-patch I printed to PDF and under the report name i see the comment, the message »Total number of rows matching the (unlimited) query is 1.« and »Rows per page« including the dropdown menu and the »Update« button. Is that expected? I attached a screenshot. I agree with Kyle that I'd expect all results to be printed, not only the first page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7646 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org