[Bug 33921] New: Improve translation of title tags: Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Bug ID: 33921 Summary: Improve translation of title tags: Plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify plugin templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve translation of |Improve translation of |title tags: Plugins |title tags: Plugins and | |Point of sale -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154698&action=edit Bug 33921: Improve translation of title tags: Plugins and Point of sale This patch updates plugin and point of sale templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Administration -> - Manage plugins - Upload plugin * With 'useplugins' set to 0 in koha-conf.xml you can navigate directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that the "Plugins disabled" page is shown. With EnablePointOfSale and UseCashRegisters enabled: - Point of sale - Make a sale and print a receipt for the transaction - Transaction history for [register] - Cash summary for [library] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154698|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155070&action=edit Bug 33921: Improve translation of title tags: Plugins and Point of sale This patch updates plugin and point of sale templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Administration -> - Manage plugins - Upload plugin * With 'useplugins' set to 0 in koha-conf.xml you can navigate directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that the "Plugins disabled" page is shown. With EnablePointOfSale and UseCashRegisters enabled: - Point of sale - Make a sale and print a receipt for the transaction - Transaction history for [register] - Cash summary for [library] Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Auld <andrew.auld@ptfs-europe.com> --- I wasn't able to do the test on the 'Plugins disabled' page as I didn't know how to change the koha-conf.xml file in a sandbox. However everything else works great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155070|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155109&action=edit Bug 33921: Improve translation of title tags: Plugins and Point of sale This patch updates plugin and point of sale templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Administration -> - Manage plugins - Upload plugin * With 'useplugins' set to 0 in koha-conf.xml you can navigate directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that the "Plugins disabled" page is shown. With EnablePointOfSale and UseCashRegisters enabled: - Point of sale - Make a sale and print a receipt for the transaction - Transaction history for [register] - Cash summary for [library] Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33921 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org