https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 183425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183425&action=edit Bug 39054: a need to distinguish between manual bibliographic record modifications and those being a consequence of authority modification Now, in action_logs, Koha does not distinguish between manual bibliographic record modifications and those being a consequence of authority modification. Both are logged in the same way: module: CATALOGUING ; operation: MODIFY ; interface: intranet. It will be helpful to be able to distinguish this two cases (for instance to be able to evaluate a librarian's 'koha' in the cataloguing process: a single action of modification of one authority record launching a modification of, say, 100 bibliographic records does not equal to manual modification of 100 bibliographic records. Also, if we trace issues in bibliographic records after modification being performed and want librarians to correct themselves, a biblio modification being a consequence of an authority modification should not be taken into account, etc.). Test plan: ========== 1. Have CataloguingLog system preference set to Log. 2. Find any bibliographic record linked with a authority record (e.g. sn:1 linked to Heylin, Clinton). 3. Modify the bibliographic record (Edit > Edit record > [make an edit] > Save). 3. In a separate tab, open the authority record and modify the heading. 4. Go back to the bibliographic record tab and chose Modification log. You will see the two recent operations marked as 'Modify'. You are not able to distinguish between the 'real' manual modification from the second being the result of an authority record modification. 5. Apply the patch ; restart all. 6. Repeat p. 3 and 4. You should now see the last action (resulting from authority modification) marked as 'Merge', which allows you to distinguish the two different actions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183427|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 183429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183429&action=edit Bug 39054: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|kyle@bywatersolutions.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183428|0 |1 is obsolete| | Attachment #183429|0 |1 is obsolete| | --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 191063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191063&action=edit Bug 39054: a need to distinguish between manual bibliographic record modifications and those being a consequence of authority modification Now, in action_logs, Koha does not distinguish between manual bibliographic record modifications and those being a consequence of authority modification. Both are logged in the same way: module: CATALOGUING ; operation: MODIFY ; interface: intranet. It will be helpful to be able to distinguish this two cases (for instance to be able to evaluate a librarian's 'koha' in the cataloguing process: a single action of modification of one authority record launching a modification of, say, 100 bibliographic records does not equal to manual modification of 100 bibliographic records. Also, if we trace issues in bibliographic records after modification being performed and want librarians to correct themselves, a biblio modification being a consequence of an authority modification should not be taken into account, etc.). Test plan: ========== 1. Have CataloguingLog system preference set to Log. 2. Find any bibliographic record linked with a authority record (e.g. sn:1 linked to Heylin, Clinton). 3. Modify the bibliographic record (Edit > Edit record > [make an edit] > Save). 3. In a separate tab, open the authority record and modify the heading. 4. Go back to the bibliographic record tab and chose Modification log. You will see the two recent operations marked as 'Modify'. You are not able to distinguish between the 'real' manual modification from the second being the result of an authority record modification. 5. Apply the patch ; restart all. 6. Repeat p. 3 and 4. You should now see the last action (resulting from authority modification) marked as 'Merge', which allows you to distinguish the two different actions. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #10 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 195825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195825&action=edit Bug 39054: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|a need to distinguish |Need to distinguish between |between manual |manual bibliographic record |bibliographic record |modifications and those |modifications and those |being a consequence of |being a consequence of |authority modification |authority modification | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #12)

1) Log editor

"Merge" is now doubled up in the list of actions.

Yes, also we already have a merge for biblios, so it would be better to do something different if a different action is the way to go.

2) How best to make the differentiation?

I can see why this change would be useful, but I wonder if we should adjust the naming of the action or even move the information into the "info" or another place instead of changing the action.

Some thoughts on this:

- Merge [MERGE] could be easily misread as meaning the action of merging 2+ bibliographic records. - It will potentially 'break' reports that look for just Modify. Depending on what you use them for this might be a breaking change for some processes. An example might be a report that is used to export changed records for an external database.

It already breaks the link from the record and doesn't show the changes because it's a hardcoded modify link. A flag in the info or like a different interface or something could be helpful? Like yes it was triggered from the staff interface, but it was edited by an automation that was triggered, so maybe an interface for those things so it would be easy to filter them out if you had a lot but could also easily tell it was from the authority update?

These action logs are still pretty "old school", the info appearing as:

biblio $VAR1 = { '_marc' => { '001' => '4327601', '005' => '20200129130616.0', '008' => '880222s1988 mnu s000 0 eng ', '010' => [ ' $a 88004763 ' ], '020' => [ ' $a 0816617112 : $c $19.95', ' $a 0816617120 (pbk.) : $c $9.95' ], '040' => [ ' $a DLC $c DLC $d DLC' ], '041' => [ '1 $a engpor' ], '050' => [ '00 $a PQ9697.L585 $b P313 1988' ], '082' => [ '00 $a 869.3 $2 19' ], '100' => [ '1 $a Lispector, Clarice.' ], '240' => [ "10 \$a Paix\x{e3}o segundo G.H. \$l English" ], '245' => [ '14 $a The passion according to G.H. / $c Clarice Lispector ; translation by Ronald W. Sousa.' ], '260' => [ ' $a Minneapolis : $b University of Minnesota Press, $c c1988.' ], '300' => [ ' $a ix, 173 p. ; $c 22 cm.' ], '440' => [ ' 0 $a Emergent literatures' ], '500' => [ " \$a Translation of: A paix\x{e3}o segundo G.H." ], '906' => [ ' $a 7 $b cbc $c orignew $d 1 $e ocip $f 19 $g y-gencatlg' ], '942' => [ ' $c BK' ], '999' => [ ' $c 438 $d 438' ] }, 'author' => 'Lispector, Clarice.', 'biblionumber' => 438, 'copyrightdate' => 1988, 'datecreated' => '2015-01-05', 'frameworkcode' => 'BKS', 'notes' => "Translation of: A paix\x{e3}o segundo G.H.", 'opac_suppressed' => 0, 'seriestitle' => 'Emergent literatures', 'title' => 'The passion according to G.H. /', 'unititle' => "Paix\x{e3}o segundo G.H." };

With the recent work on improving the logs I nwonder if there is another option we could use to include the information about "auto-authority updates" in another way?

Adding Lisette for second opinion.

The diff does look nice, which is the more modern view (column is currently hidden by default and needs to be reloaded after it's turned on, need to file a followup for that) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #15 from Lisette Scheer <lisette@bywatersolutions.com> --- I think doing something with the script column might be ideal, as well as making it visible and filterable: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39910 Currently only crons are logged there I think, but logging changes to bibs that are triggered by something else (like authority records) seems like a great way to handle this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #16 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #12)

1) Log editor

"Merge" is now doubled up in the list of actions.

How about "Heading sync" (and HEADING_SYNC as a technical action's code)? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #17 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 207529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207529&action=edit Bug 39054: a need to distinguish between manual bibliographic record modifications and those being a consequence of authority modification Now, in action_logs, Koha does not distinguish between manual bibliographic record modifications and those being a consequence of authority modification. Both are logged in the same way: module: CATALOGUING ; operation: MODIFY ; interface: intranet. It will be helpful to be able to distinguish this two cases (for instance to be able to evaluate a librarian's 'koha' in the cataloguing process: a single action of modification of one authority record launching a modification of, say, 100 bibliographic records does not equal to manual modification of 100 bibliographic records. Also, if we trace issues in bibliographic records after modification being performed and want librarians to correct themselves, a biblio modification being a consequence of an authority modification should not be taken into account, etc.). Test plan: ========== 1. Have CataloguingLog system preference set to Log. 2. Find any bibliographic record linked with a authority record (e.g. sn:1 linked to Heylin, Clinton). 3. Modify the bibliographic record (Edit > Edit record > [make an edit] > Save). 3. In a separate tab, open the authority record and modify the heading. 4. Go back to the bibliographic record tab and chose Modification log. You will see the two recent operations marked as 'Modify'. You are not able to distinguish between the 'real' manual modification from the second being the result of an authority record modification. 5. Apply the patch ; restart all. 6. Repeat p. 3 and 4. You should now see the last action (resulting from authority modification) marked as 'Merge', which allows you to distinguish the two different actions. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Janusz Kaczmarek <januszop@gmail.com> --- Corrected, rebased. Needs fresh SO. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #20 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 207531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207531&action=edit Bug 39054: a need to distinguish between manual bibliographic record modifications and those being a consequence of authority modification Now, in action_logs, Koha does not distinguish between manual bibliographic record modifications and those being a consequence of authority modification. Both are logged in the same way: module: CATALOGUING ; operation: MODIFY ; interface: intranet. It will be helpful to be able to distinguish this two cases (for instance to be able to evaluate a librarian's 'koha' in the cataloguing process: a single action of modification of one authority record launching a modification of, say, 100 bibliographic records does not equal to manual modification of 100 bibliographic records. Also, if we trace issues in bibliographic records after modification being performed and want librarians to correct themselves, a biblio modification being a consequence of an authority modification should not be taken into account, etc.). Test plan: ========== 1. Have CataloguingLog system preference set to Log. 2. Find any bibliographic record linked with a authority record (e.g. sn:1 linked to Heylin, Clinton). 3. Modify the bibliographic record (Edit > Edit record > [make an edit] > Save). 3. In a separate tab, open the authority record and modify the heading. 4. Go back to the bibliographic record tab and chose Modification log. You will see the two recent operations marked as 'Modify'. You are not able to distinguish between the 'real' manual modification from the second being the result of an authority record modification. 5. Apply the patch ; restart all. 6. Repeat p. 3 and 4. You should now see the last action (resulting from authority modification) marked as 'Heading sync', which allows you to distinguish the two different actions. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207531|0 |1 is obsolete| | Attachment #207532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39054 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 211647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211647&action=edit Bug 39054: Unit tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.