[Bug 34818] New: Cannot perform batch patron modification without selecting a patron attribute
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Bug ID: 34818 Summary: Cannot perform batch patron modification without selecting a patron attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart+koha@gmail.com Depends on: 21083 I've been testing batch patron modification while working on Bug 33927 and have found that if I submit a batch of patrons for modification I have to select a patron attribute or the process will fail: Can't call method "category_code" on an undefined value at /kohadevbox/koha/tools/modborrowers.pl line 407 It doesn't appear to matter how the batch is submitted, whether it be cardnumbers, borrowernumbers, or patron list. It looks to me like Bug 21083 is the cause. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21083 [Bug 21083] Batch patron modification does not allow to modify repeatable patron attributes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155854&action=edit Bug 34818: (bug 21083 follow-up) Fix batch patron modification tool It is not possible to perform batch patron modification without selecting a patron attribute Test plan: Test the batch patron modification tool, with or without extended attributes. The error was Can't call method "category_code" on an undefined value at /kohadevbox/koha/tools/modborrowers.pl line 407 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155854|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 155859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155859&action=edit Bug 34818: (bug 21083 follow-up) Fix batch patron modification tool It is not possible to perform batch patron modification without selecting a patron attribute Test plan: Test the batch patron modification tool, with or without extended attributes. The error was Can't call method "category_code" on an undefined value at /kohadevbox/koha/tools/modborrowers.pl line 407 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155859|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155860&action=edit Bug 34818: (bug 21083 follow-up) Fix batch patron modification tool It is not possible to perform batch patron modification without selecting a patron attribute Test plan: Test the batch patron modification tool, with or without extended attributes. The error was Can't call method "category_code" on an undefined value at /kohadevbox/koha/tools/modborrowers.pl line 407 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue with release notes| |batch patron modifications | |that was introduced by bug | |21083 - you can now | |successfully perform a | |batch update without | |needing to select patron | |attributes. Previously, if | |you submitted a batch of | |patrons for modification, | |you needed to select a | |patron attribute or the | |process will fail with an | |error trace. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes using KTD: 1. Used patrons listed at the end to test. 2. Was able to replicate the issue. 3. Changed library location and set up a patron attribute to test. 4. Noted that with Patron attributes, if you tick the box 'check to delete this field' but put a different value in the field, it updates with the new value rather than deleting. Not sure whether this is intended behavour. Patrons used for testing: 23529000035676 23529001000463 23529000050113 19 45 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 21083 not yet in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34818 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends in Bug 21083 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org