[Bug 24095] New: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Bug ID: 24095 Summary: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org On the "my summary" page in the OPAC, under the holds tab, clicking the delete button for a hold should trigger a confirmation message. The MSG_CONFIRM_DELETE_HOLD is not defined so the confirmation is skipped and the hold is deleted without confirmation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |21772 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- From commit 6a7d4b19c7fa224fc1a5abd596a81d3ca52f43f9 Bug 21772: Move OPAC holds and account tables into .inc Also needed in sco/sco-main.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |agustinmoyano@theke.io CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|agustinmoyano@theke.io |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 96795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96795&action=edit Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page This patch corrects markup in the table of holds in the OPAC so that the hold deletion confirmation message appears correctly. The onclick event removed from holds-table.inc was made obsolete by Bug 21870. To test, apply the patch and log in to the OPAC as a user who has holds. - From the "your summary" page in the OPAC, open the holds tab. - Click any "Cancel" button. You should be shown a confirmation modal. - Test both the confirm and cancel operations. - Log in to self-checkout and confirm that the holds tab there is unaffected: Although it uses the same include, the hold cancellation option isn't shown there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I duped my own patch! *** This bug has been marked as a duplicate of bug 24433 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org